Bug 73089

Summary: pseudoramix not conditional on xinerama support
Product: xorg Reporter: lonefox
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED MOVED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Fix building without Xinerama none

Description lonefox 2013-12-28 07:03:21 UTC 
libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../include -DHAVE_DIX_CONFIG_H -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Wlogical-op -Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type -Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing -fno-strict-aliasing -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/usr/include/X11/dri -I/usr/include/libdrm -I/usr/include/pixman-1 -I/usr/include/freetype2 -I../include -I../include -I../Xext -I../composite -I../damageext -I../xfixes -I../Xi -I../mi -I../miext/sync -I../miext/shadow -I../miext/damage -I../render -I../randr -I../fb -I../dbe -fvisibility=hidden -s -Wall -O2 -march=native -frename-registers -pipe -MT pseudoramiX.lo -MD -MP -MF .deps/pseudoramiX.Tpo -c pseudoramiX.c  -fPIC -DPIC -o .libs/pseudoramiX.o
pseudoramiX.c:45:43: fatal error: X11/extensions/panoramiXproto.h: No such file or directory
compilation terminated.
Makefile:576: recipe for target 'pseudoramiX.lo' failed
make[1]: *** [pseudoramiX.lo] Error 1
make[1]: Leaving directory '/mnt/pkg/pkgmk_work/xorg-server/src/xorg-server-1.15.0/pseudoramiX'
Makefile:736: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1

The missing header appears to be from xineramaproto, which is supposed to be optional (and obsolete/deprecated)...
Comment 1 Alan Coopersmith 2013-12-28 08:10:50 UTC 
The Xinerama protocol is neither obsolete nor deprecated, but it may be optional.
Comment 2 Leandro Nini 2014-01-02 18:52:39 UTC 
Created attachment 91429 [details] [review]
Fix building without Xinerama

The attached patch skips pseudoramiX dir if xinerama is not found at configure time avoiding build failure
Comment 3 Adam Jackson 2018-06-13 18:25:25 UTC 
This patch isn't quite right, the conditional there now says if PSEUDORAMIX already, and the equivalent change would need to happen for meson too.
Comment 4 GitLab Migration User 2018-12-13 22:29:34 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/xserver/issues/451.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.