Summary: | Screen doesn't turn on after DPMS standby and subseqent suspend | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | xorg | Reporter: | Alexander Mezin <mezin.alexander> | ||||||||||
Component: | Driver/intel | Assignee: | Chris Wilson <chris> | ||||||||||
Status: | RESOLVED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||||||
Severity: | normal | ||||||||||||
Priority: | medium | CC: | andyrtr, rdieter | ||||||||||
Version: | 7.7 (2012.06) | ||||||||||||
Hardware: | x86-64 (AMD64) | ||||||||||||
OS: | Linux (All) | ||||||||||||
Whiteboard: | |||||||||||||
i915 platform: | i915 features: | ||||||||||||
Attachments: |
|
Description
Alexander Mezin
2013-12-31 05:35:36 UTC
Some details: It happens on laptop HP Pavilion dv6-6179er Kernel command line includes "acpi_backlight=vendor" Setting backlight level to 0 also turns off the screen (In reply to comment #0) > After > $ xset dpms force standby && xset dpms force suspend Are both of those actually required to reproduce? The kernel driver basically maps both of those to dpms off. > screen turns off and doesn't turn on back when I move mouse or press keys And what about xset dpms force on? Only suspend, only standby or only "force off" works fine - screen turns on after short delay "xset dpms force on" doesn't help I only can get backlight back by pressing "increase brightness" key multiple times. It starts increasing from 0. What does xrandr --verbose report before/after the blank screen? And cat /sys/class/backlight/*/* After your wiggle your mouse can you see anything on the screen at all? (shine a light on it and look at an oblique angle.) That will help us figure out if it is just the backlight that is failing to be controlled. Created attachment 91367 [details]
info when backlight is on
xrandr --verbose, cat /sys/class/backlight/*/* when backlight is on
Created attachment 91368 [details]
info when backlight is off
xrandr --verbose, cat /sys/class/backlight/*/*
after xset dpms force standby && xset dpms force suspend
Just after dpms standby && dpms suspend screen is completely black. After I moved mouse it isn't blank, just without backlight. And your Xorg.0.log? Note that there is a fix in 2.99.905 for backlight being set to zero if queried (via xrandr) whilst the screen is off. Tried 2.99.907 - this problem is fixed in it, but only for sna. Could you backport it to uxa too? Created attachment 91484 [details]
Xorg.0.log with UXA
Created attachment 91485 [details] [review] Possible fix Looks like I've fixed it for UXA by myself Also, maybe in sna_output_dpms "dpms" should be compared with DPMSModeOn instead of DPMSModeOff. I think standby and suspend should be handled in the same way as off. At least, backlight didn't turn on until I changed it in uxa. commit 82fa7ec352426c7e3d5210aac8ea1030232cc0f3 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Mon Jan 6 14:30:56 2014 +0000 uxa: Always treat DPMSModeSuspend/Standby similar to DPMSModeOff As we assume that Suspend, Standby alias to Off and disable the crtc when switching to any mode other than On, we need to also perform the backlight updates for Suspend,Standby prior to passing the DPMS value onto the kernel. Suggested-by: Alexander Monakov <amonakov@gmail.com> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> commit 28a057105b6974803aee0d68c2a71f322095dfde Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Mon Jan 6 14:37:09 2014 +0000 uxa: Disable updating properties upon reading their values Backport commit e76b08cad2770015346fd4cd757de3bb3b6ff37c Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Tue Oct 15 12:46:09 2013 +0100 sna: Disable updating properties upon reading their values in order to prevent random screen blanking upon return from DPMS. Reported-by: Alexander Monakov <amonakov@gmail.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73181 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> commit 0138b38dfcd933d080f86cfd33664eeb3f5558a0 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Mon Jan 6 14:30:56 2014 +0000 sna: Always treat DPMSModeSuspend/Standby similar to DPMSModeOff As we assume that Suspend, Standby alias to Off and disable the crtc when switching to any mode other than On, we need to also perform the backlight updates for Suspend,Standby prior to passing the DPMS value onto the kernel. Suggested-by: Alexander Monakov <amonakov@gmail.com> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Everything is fine except Suggested-by :)) I don't insist on correcting this. Next time I must not be lazy and should send properly formatted patches to mailing list instead... Meh, you got suggested-by on the uxa since it was just a cut'n'paste... |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.