Bug 73213

Summary: [IVB/HSW/BYT Regression] 3D performance (smokin-guns, padman, urbanterror) reduced by ~10%
Product: xorg Reporter: zhoujian <jianx.zhou>
Component: Driver/intelAssignee: Chris Wilson <chris>
Status: VERIFIED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: major    
Priority: high CC: chris, eero.t.tamminen, lilix.cheng, wendy.wang
Version: git   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
1.14.5_Xorg.0.log
none
1.15.99.900_Xorg.0.log none

Description zhoujian 2014-01-02 07:22:28 UTC
System Environment:       
----------------------------------------------
Platform: IVB
Libdrm: (master)libdrm-2.4.50-5-ge8cbc579651ef55274763c67acb
Mesa: (master)5a51c1b01a16d3256f9769a76d8293fea5853b1f
Xserver:(master)xorg-server-1.15.0
Xf86_video_intel: (master)2.99.907
Cairo:(master)2974416dfc56e1b3a59001e482679f8601abd7d5
Libva:(staging)d349f2bb779c596290a493f3c1344f912565e568
Libva_intel_driver: (staging)e2e4898bd60aed48b260a4bc380
Kernel: git-a7c1d426e

Bug detailed description:
----------------------------------------------
3D performance(Smokin-guns,padman,urbanterror)reduced by ~10% on IVB. 
The problem exists on both gnome-session and Raw X. It works well on HSW/BYT-M.

It’s Xserve regression. As I known, the good commit is git-264fc3a.
It can’t be bisected because errors with “Fatal server error:”. 

Performance status
--------------------------------------------------------------------
Test on IVB
                git-2ea973e     git-264fc3a
padman,          158.1fps         184.6fps
smokin-guns,     136.4fps         152.5fps
urbanterror,     110.7fps         120fps

Reproduce steps:
---------------------------------------------
1. xinit&
2. vblank_mode=0 ./smokinguns.x86_64 +set r_fullscreen 1 +timedemo 1 +set demodone "quit" +set demoloop1 "demo pts; set nextdemo vstr demodone" +vstr demoloop1 +set r_customwidth 1920 +set r_customheight 1080
Comment 1 zhoujian 2014-01-09 09:43:23 UTC
The problem also exists on HSW/BYT.
Comment 2 Chris Wilson 2014-01-15 13:16:51 UTC
I don't see any significant difference between 1.14.5 and 1.15.99.900 on ivb i7-3720qm.

Let's start with Xorg.0.log from both versions and see if there are any significant feature differences.
Comment 3 zhoujian 2014-01-16 03:31:41 UTC
(In reply to comment #2)
> I don't see any significant difference between 1.14.5 and 1.15.99.900 on ivb
> i7-3720qm.

Let's start with Xorg.0.log from both versions and see if there
> are any significant feature differences.
Okay,I have upload Xorg.0.log,please see 1.14.5_Xorg.0.log and 1.15.99.900_Xorg.0.log
Comment 4 zhoujian 2014-01-16 03:32:55 UTC
Created attachment 92204 [details]
1.14.5_Xorg.0.log
Comment 5 zhoujian 2014-01-16 03:33:27 UTC
Created attachment 92205 [details]
1.15.99.900_Xorg.0.log
Comment 6 Daniel Vetter 2014-03-05 16:48:03 UTC
Fix landed in dinq:

commit 8ea99c928787ba1712b7506b4c56c948c45d84b1
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Fri Feb 14 14:01:21 2014 +0100

    drm/i915: Only bind each object rather than for every execbuffer
Comment 7 zhoujian 2014-03-06 09:20:14 UTC
With above the patch(git-8ea99c9) that the problem can't fixed.
Comment 8 Daniel Vetter 2014-03-10 09:44:02 UTC
Oh, closed the wrong bug report by accident ;-)
Comment 9 Mika Kuoppala 2014-11-06 15:40:41 UTC
(In reply to zhoujian from comment #7)
> With above the patch(git-8ea99c9) that the problem can't fixed.

Is the issue still in dinq?
Comment 10 wendy.wang 2014-11-18 05:35:16 UTC
This issue has been fixed running on latest gfx sw drivers:2014-11-07

 Libdrm:		(master)libdrm-2.4.58-4-g00847fa48b83a85b0cb882594a12ed1511f780db
 Mesa:		(master)876c53375e58a19f8fa1681ae235b463a5781f46
 Xserver:		(master)xorg-server-1.16.99.901-3-g63bb5c5ef16edf652179770294dcca4fc07dc992
 Xf86_video_intel:		(master)2.99.916-145-g6c2707d7bbc0ebb422be66618b6f78887c46446e
 Cairo:		(master)121f384c0e231c9c5d9c937b216d342bfc7810a6
 Libva:		(master)f9309a6f44b51bb2c463a6a16d3ccf3edc6e6c7a
 Libva_intel_driver:		(master)8e34fb34ed402811e512f9d41b14345f3795bac5
 Kernel:   (drm-intel-nightly)e49ebf9ed863e9522260ebd7bd0338ef5641c0e6

On IVB-M Performance results:
KPIs	Mesa_U_IVB_M(2014-11-17)  (2014-01-02)	2014-11-17 VS 2014-01-02
Padman v1.2	137.7	            92.2       49.35%
Smokin-Guns    123.8	            74.4       66.40%
UrbanTerror     89.9	            62.4       44.07%

Close this bug as fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.