Bug 73708

Summary:	\+ does not work with FreeBSD sed
Product:	Zeitgeist	Reporter:	Ting-Wei Lan <lantw44>
Component:	libzeitgeist	Assignee:	zeitgeist-bugs <zeitgeist-bugs>
Status:	RESOLVED FIXED	QA Contact:	zeitgeist-bugs <zeitgeist-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	FreeBSD
Whiteboard:
i915 platform:		i915 features:
Attachments:	Replace \+ with \{1,\)

Description Ting-Wei Lan 2014-01-16 16:55:53 UTC

Created attachment 92239 [details]
Replace \+ with \{1,\)

This command
/usr/bin/sed -n "s/^dlname='\([A-Za-z0-9.+-]\+\)'/\1/p" libzeitgeist-2.0.la

does not work on FreeBSD because \+ is not in basic regular expression.

Comment 1 Allison Lortie (desrt) 2014-01-30 13:21:39 UTC

A bit of research shows

 1) in its manpage, sed claims to conform to POSIX BRE

 2) POSIX BRE specifies {n,m} but it does not specify +

This patch therefore seems correct.

Comment 2 Seif Lotfy 2014-01-30 13:29:27 UTC

Ah merged this to master but forgot to close. Thanks Ting :D

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.