Bug 73808

Summary:	loader.c(90) : error C2365: 'log' : redefinition; previous definition was 'function'
Product:	Mesa	Reporter:	Vinson Lee <vlee>
Component:	Mesa core	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:
Severity:	blocker
Priority:	medium	CC:	emil.l.velikov
Version:	git	Keywords:	regression
Hardware:	x86-64 (AMD64)
OS:	Windows (All)
Whiteboard:
i915 platform:		i915 features:

Description Vinson Lee 2014-01-19 19:39:32 UTC

mesa: ad3c99e22a688b7c3f15894aabbedcc5cd89230b (master)

MSVC build regression

  Compiling src\loader\loader.c ...
loader.c
src\loader\loader.c(90) : error C2365: 'log' : redefinition; previous definition was 'function'
src\loader\loader.c(313) : error C2167: 'log' : too many actual parameters for intrinsic function
src\loader\loader.c(320) : warning C4133: '=' : incompatible types - from 'void (__cdecl *)(int,const char *,...)' to 'double (__cdecl *)()'
src\loader\loader.c(320) : error C2106: '=' : left operand must be l-value
src\loader\loader.c(320) : warning C4550: expression evaluates to a function which is missing an argument list

Comment 1 Vinson Lee 2014-01-20 19:20:09 UTC

commit d43260b59e1db8261bf581f5316d7634b7102ff6
Author: José Fonseca <jfonseca@vmware.com>
Date:   Mon Jan 20 13:57:12 2014 +0000

    logger: s/\<log\>/log_/
    
    Currently the MSVC build is broken because of conflicting definitions of
    'log' function.  I didn't investigate thoroughly, but I suspect the
    it is conflicting standard math.h's log.
    
    log_ is admittedly not a great name, but it is better than a broken build.
    A better one can be used in a follow-on build.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.