| Summary: | #!/usr/bin/python in data/ontology2code | ||
|---|---|---|---|
| Product: | Zeitgeist | Reporter: | Ting-Wei Lan <lantw44> |
| Component: | libzeitgeist | Assignee: | zeitgeist-bugs <zeitgeist-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | zeitgeist-bugs <zeitgeist-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | big.boo.oitnb.2000, lantw44 |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | FreeBSD | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
[PATCH] ontology2code: don't hardcode python path
[PATCH] test/dbus: don't hardcode python path |
||
|
Description
Ting-Wei Lan
2014-01-20 15:22:19 UTC
This script doesn't get installed so it would probably be easier to just use the typical 'env' trick... ie: #!/usr/bin/env python (In reply to comment #1) > This script doesn't get installed so it would probably be easier to just use > the typical 'env' trick... Some systems don't install the python binary as 'python' but rather as python2 or python2.7 or python3.3 ... and such. If we can detect the correct python binary in configure, we can use @PYTHON@ or modify the Makefile to use $(PYTHON) to execute the script. (In reply to comment #3) > If we can detect the correct python binary in configure, we can use @PYTHON@ > or modify the Makefile to use $(PYTHON) to execute the script. Here are the files where 'python' or '/usr/bin/python' is hardcoded. And yes, I agree we could use @PYTHON@ (and something like $PYTHON in configure.ac). Tests and tools might not be that big of a deal since they're not installed/run as part of the build afaics and one can always run then manually using the correct path to the python interpreter. configure.ac data/ontology2code test/dbus/monitor-test.py test/dbus/upgrade-test.py test/dbus/remote-test.py test/dbus/engine-test.py test/dbus/histogram-test.py test/dbus/result-types-test.py test/dbus/blacklist-test.py test/dbus/run-all-tests.py test/dbus/dsr-test.py tools/tali Created attachment 95858 [details]
[PATCH] ontology2code: don't hardcode python path
Use the typical /usr/bin/env trick to find python.
Created attachment 113084 [details] [review] [PATCH] test/dbus: don't hardcode python path I find we still need to patch several files in test/dbus to make the test work. commit 12b291c2cc516ad9b1c4943b0e5d7501853fd330 Author: Ting-Wei Lan <lantw@src.gnome.org> Date: Tue Feb 3 14:24:42 2015 +0800 test/dbus: don't hardcode python path https://bugs.freedesktop.org/show_bug.cgi?id=73837 commit d36d90fd0366b84c2e466963c49ad4b48ca740cb Author: Ryan Lortie <desrt@desrt.ca> Date: Sat Mar 15 11:40:10 2014 -0400 ontology2code: don't hardcode python path Use the typical /usr/bin/env trick to find python. https://bugs.freedesktop.org/show_bug.cgi?id=73837 Comment on attachment 95858 [details]
[PATCH] ontology2code: don't hardcode python path
persons i.d search
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.