Bug 73842

Created attachment 92479 [details]
dmesg

Created attachment 92480 [details]
strace of i3lock including when i close/open lid

Try not enabling TearFree.

You're spot on. Disabling TearFree solved the issue.

Furthermore, testing i3lock using the fbdev xorg driver with the nomodeset kernel commandline option also did not reproduce the issue.

Do you have any idea what in the TearFree code might be causing this?

Thanks,
uriah

Nope. Give me a Xorg.0.log with --enable-debug=full and I might be able to piece together where the i3lock buffer went.

Created attachment 92492 [details]
Xorg.0.log with --enable-debug=full (segmentation fault)

Ok, here you go. I'm not sure whether it segfaults when the lid closes or opens... When I opened the lid it showed the VT and then went to a black screen that I couldn't get out of.

Cheers,
uriah

Created attachment 92494 [details]
Xorg.0.log from git master with --enable-debug=full

Ah, when waking up from DPMS off we bind a dirty framebuffer. That lasts for a whole 1s before the screen is finally refreshed with the correct content. Does that match your experience?

My theory is that this should be fixed by:

diff --git a/src/sna/sna_display.c b/src/sna/sna_display.c
index 000d9ab..5ab42ec 100644
--- a/src/sna/sna_display.c
+++ b/src/sna/sna_display.c
@@ -1422,6 +1422,8 @@ static struct kgem_bo *sna_crtc_attach(xf86CrtcPtr crtc)
 
                DBG(("%s: attaching to single shadow pixmap\n", __FUNCTION__));
                if (sna->mode.shadow == NULL) {
+                       BoxRec box;
+
                        bo = kgem_create_2d(&sna->kgem,
                                            sna->scrn->virtualX,
                                            sna->scrn->virtualY,
@@ -1431,6 +1433,18 @@ static struct kgem_bo *sna_crtc_attach(xf86CrtcPtr crtc)
                        if (bo == NULL)
                                return NULL;
 
+                       box.x1 = box.y1 = 0;
+                       box.x2 = sna->scrn->virtualX;
+                       box.y2 = sna->scrn->virtualY;
+
+                       if (!sna->render.copy_boxes(sna, GXcopy,
+                                                   sna->front, sna_pixmap(sna->front)->gpu_bo, 0, 0,
+                                                   sna->front, bo, 0, 0,
+                                                   &box, 1, 0)) {
+                               kgem_bo_destroy(&sna->kgem, bo);
+                               return NULL;
+                       }
+
                        if (!get_fb(sna, bo,
                                    sna->scrn->virtualX,
                                    sna->scrn->virtualY)) {

It works!

Cheers!
uriah

p.s. where should I file a report about the screen not automatically shutting off when lid is closed? That's supposed to happen, right?

(In reply to comment #10)
> p.s. where should I file a report about the screen not automatically
> shutting off when lid is closed? That's supposed to happen, right?

Hmm, yes. Kernel detects lid event, sends hotplug notification, userspace wakes up sees the lid is closed and/or the panel is disconnected and turns off the panel. (Any one of those steps may be at fault - you can at least watch what userspace does by tracing X, it serves as the hub for events and commands). Sometimes this is complicated by the firmware interceding and turning things off on its own accord.

commit 2c441079cbd52902d356b652659e2be84726940e
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue Jan 21 10:17:03 2014 +0000

    sna: Initialise the TearFree shadow output from the current front buffer
    
    Otherwise we may end up in a sitation where we show stale contents for a
    (sometimes signification) fraction of a second before it is refreshed
    with the correct contents.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73842
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>