Bug 74031

Summary: xorg/util/imake/Makefile.am: gcc4.8's cpp breaks shebangs in xmkmf, others
Product: xorg Reporter: Greg Turner <gmt>
Component: Build/MonolithicAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: git   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Fix Makefile.am none

Description Greg Turner 2014-01-24 21:09:05 UTC 
Created attachment 92745 [details]
Fix Makefile.am

see #69439.

Makefile.am's recipes for shell scripts result in tons of blank lines before the shabangs, against gcc4.8+ cpp's.  Zany antics ensue.

Enclosed patch replicates fix that went in for #69439.  W4M and other reporter in #69439.

But... I wasn't sure if Makefile.am here is generated?

If so, sorry, but actual right thing to do should be readily deducible from the enclosed to the appropriate SME.
Comment 1 Julien Cristau 2014-03-24 19:48:31 UTC 
http://cgit.freedesktop.org/xorg/util/imake/commit/?id=16e54de5d8c58a1d051a5f4bcb7357aa9f9facff

commit 16e54de5d8c58a1d051a5f4bcb7357aa9f9facff
Author: Greg Turner <gmt@be-evil.net>
Date:   Mon Mar 24 20:37:15 2014 +0100

    Pass files to cpp via CLI arg instead of stdin to workaround gcc 4.8 change
    
    Replicates Alan Coopersmith's fix for xinit.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74031
    
    Signed-off-by: Julien Cristau <jcristau@debian.org>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.