Summary: | [IVB/HSW/BYT-M bisected]GLBenchmark crashes | ||
---|---|---|---|
Product: | Mesa | Reporter: | zhoujian <jianx.zhou> |
Component: | Drivers/DRI/i965 | Assignee: | Matt Turner <mattst88> |
Status: | VERIFIED FIXED | QA Contact: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
Severity: | major | ||
Priority: | high | CC: | eero.t.tamminen, huax.lu, idr |
Version: | git | ||
Hardware: | All | ||
OS: | Linux (All) | ||
URL: | http://patchwork.freedesktop.org/patch/18801/ | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
dmesg.log
Xorg.0.log outfile.log |
Description
zhoujian
2014-01-26 06:20:23 UTC
Created attachment 92797 [details]
dmesg.log
Created attachment 92798 [details]
Xorg.0.log
Created attachment 92799 [details]
outfile.log
I think Matt may already have a patch on the mailing list for this... *** Bug 74069 has been marked as a duplicate of this bug. *** Thanks for the bug report. Looks like just a misunderstanding on my part of the GLSL ES spec. (My outstanding patch shouldn't affect this bug) After stating > Each compilation unit should declare the version of the language it is written > to using the #version directive: > #version number the GLSL ES 1.0 spec continues > "Version 100 of the language does not require compilation units to include this > directive, and compilation units that do not include a #version directive will > be treated as targeting version 100." Spec authors should not use "should"! I don't see how this worked before my commit either, unless by setting language_version = 110 we coincidentally passed some (version >= 100) checks? Patch on the list. With patch http://patchwork.freedesktop.org/patch/18801/ test that problem still being. (In reply to comment #8) > With patch http://patchwork.freedesktop.org/patch/18801/ test that problem > still being. Are you sure you were testing the patched Mesa? I haven't tested GLB2.5, but I was able to reproduce the problem with GLB2.7 before my patch. After applying the patch I cannot reproduce the problem. sorry,I missed something with your patch. Retest it, problem is fixed. Commit b2d1c579bb84a88179072a6a783f8827e218db55 also broke Weston w/cairo-glesv2 and causes the following errors from cairo-gl-shaders: OpenGL shader compilation failed. Shader: #ifdef GL_ES precision mediump float; #endif uniform vec4 color; void main() { gl_FragColor = color; } OpenGL compilation log: 0:4(14): error: no precision specified this scope for type `vec4' weston-desktop-shell: cairo-gl-shaders.c:761: compile_shader: Assertion `!"reached"' failed. I tested the patch at http://patchwork.freedesktop.org/patch/18801/ and it fixes things for me. Thanks guys! Committed as http://cgit.freedesktop.org/mesa/mesa/commit/?id=c59a605c70752b584a05bc6f129a1aa894c861ce Verified it. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.