| Summary: | Telepathy projects should have GNOME-style installed tests | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | general | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | xclaesse |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | 76688, 76690 | ||
| Bug Blocks: | |||
| Attachments: |
[MC] run-test.sh: output in TAP format, and install an installed-tests wrapper
All C/C++ tests: run with temporary XDG_*_HOME, XDG_RUNTIME_DIR All C/C++ tests: run with temporary XDG_*_HOME, XDG_RUNTIME_DIR |
||
|
Description
Simon McVittie
2014-02-06 16:17:24 UTC
Created attachment 93542 [details] [review] [MC] run-test.sh: output in TAP format, and install an installed-tests wrapper See: https://wiki.gnome.org/action/show/Initiatives/GnomeGoals/InstalledTests https://en.wikipedia.org/wiki/Test_Anything_Protocol --- As a starting point, here's Mission Control. Comment on attachment 93542 [details] [review] [MC] run-test.sh: output in TAP format, and install an installed-tests wrapper Review of attachment 93542 [details] [review]: ----------------------------------------------------------------- ++ *** Bug 27862 has been marked as a duplicate of this bug. *** Comment on attachment 93542 [details] [review] [MC] run-test.sh: output in TAP format, and install an installed-tests wrapper applied in master and next telepathy-glib installed tests (also GTest everywhere, as Bug #27862 asked): http://cgit.freedesktop.org/~smcv/telepathy-glib/log?h=next-tap (In reply to comment #5) > telepathy-glib installed tests Still to do: the Logger tests aren't installable. They'll need some alterations for that, I suspect. MC installed-tests improvements (for master, but should also work for next): http://cgit.freedesktop.org/~smcv/telepathy-mission-control/log/?h=tests - "run-test.sh: run in a temporary XDG_DATA_HOME etc.": We don't do that when running "make check", if you need it for installed tests we probably need it for make check as well, no? Note that tests/dbus/contacts.c at least already does it from C code. I should push again for my helpers for setting those in glib: https://bugzilla.gnome.org/show_bug.cgi?id=674197. - "util-cxx.cpp: convert to GTest": please squash it with the other commit before merging. (In reply to comment #8) > - "run-test.sh: run in a temporary XDG_DATA_HOME etc.": We don't do that > when running "make check", if you need it for installed tests we probably > need it for make check as well, no? Maybe. I'll check. > - "util-cxx.cpp: convert to GTest": please squash it with the other commit > before merging. Sure. tests/Makefile.am: no special variables tests/dbus/Makefile.am: XDG_DATA_HOME, XDG_DATA_DIRS tests/logger/Makefile.am: XDG_DATA_HOME tests/logger/dbus/Makefile.am: XDG_DATA_HOME, XDG_DATA_DIRS ... so yes, these places should ideally all disarm XDG_CONFIG_HOME, XDG_CACHE_HOME and XDG_RUNTIME_DIR too. (In reply to comment #8) > if you need it for installed tests we probably > need it for make check as well, no? I don't think we strictly *need* to disarm XDG_CACHE_HOME, XDG_CONFIG_HOME and XDG_RUNTIME_DIR for the installed-tests right now, but it seems good to isolate them more thoroughly in case libraries we depend on make more use of those variables. Created attachment 96288 [details] [review] All C/C++ tests: run with temporary XDG_*_HOME, XDG_RUNTIME_DIR These aren't currently used, so we don't actually create them. --- In addition to what was previously in the branch. Created attachment 96306 [details] [review] All C/C++ tests: run with temporary XDG_*_HOME, XDG_RUNTIME_DIR These aren't currently used, so we don't actually create them... except for tests/logger/dbus/tmp-cache/telepathy/logger/sqlite-data, which is in fact created by running the tests. --- Previous patch broke distcheck. +1. I still prefer doing it from the C code so we can safely just run ./foo without needing to set env, but we are not there yet. Comment on attachment 96306 [details] [review] All C/C++ tests: run with temporary XDG_*_HOME, XDG_RUNTIME_DIR Merged for 0.99.9 > MC installed-tests improvements (for master, but should also work for next) Actually, never mind master, let's just do this on next. (Branch is relative to next-import which is Bug #70991.) http://cgit.freedesktop.org/~smcv/telepathy-mission-control/log?h=next-tests&cache=please-dont Collecting the branches for this so far, including the one for Idle that I've just done: http://cgit.freedesktop.org/~smcv/telepathy-mission-control/log?h=next-tests http://cgit.freedesktop.org/~smcv/telepathy-gabble/log?h=next-tests http://cgit.freedesktop.org/~smcv/telepathy-idle/log?h=next-tests Salut, Rakia and Haze to go. I expect them to look a lot like Idle. (In reply to comment #17) > Salut, Rakia and Haze to go. I expect them to look a lot like Idle. Gabble, MC, Idle and Rakia merged in or before 0.99.11. Just Salut and Haze to go. Salut and Haze also merged. Fixed in git for 0.99.11. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.