Summary: | Cell Borders not exported properly to XLS | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Ashok <ashokintvm> |
Component: | Spreadsheet | Assignee: | Kohei Yoshida (inactive) <libreoffice> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | critical | ||
Priority: | highest | CC: | DaveJakeman, libreoffice, luetzz, mst.fdo, ox, richardslipper01, stroghov, suokunlong, vyrza.azryansyah |
Version: | 4.2.1.1 release | Keywords: | regression |
Hardware: | Other | ||
OS: | All | ||
See Also: |
https://bugs.freedesktop.org/show_bug.cgi?id=68148 https://bugs.freedesktop.org/show_bug.cgi?id=73487 https://bugs.freedesktop.org/show_bug.cgi?id=79787 |
||
Whiteboard: | target:4.3.0 target:4.2.2 | ||
i915 platform: | i915 features: | ||
Attachments: |
document before save
document on save document after reopening Test document that contains ALL Excel line types. screenshot, LiO v 4.2.4.2 (same applies for 4.2.5.2) screenshot, LiO v 4.2.4.2 (same applies for 4.2.5.2) |
Description
Ashok
2014-02-18 06:01:23 UTC
Repro in 4.2.1.1, ubuntu 13.10 x86. Is a regression against 4.2.0 release. Set as Highest Critial. This issue not only happen when export to .xls, but also .xlsx. Created attachment 94402 [details]
document before save
Created attachment 94403 [details]
document on save
Created attachment 94404 [details]
document after reopening
Any New Border added on cells getting lost on saving as xls file. Version with problem is 4.2.1 rc1. Used OS windows XP sp3 Existing border preserves saved using old versions & copy-paste also preserves on save. But If add a new border, on save it lost & reopen shows no border. guess it's most likely due to big border re-write (commit 9a19e8d838753128504274e1885eb3ce8ec1dbb8) In my testing, only the hairline is lost on save, while the rest look okay. Created attachment 94443 [details]
Test document that contains ALL Excel line types.
Test document that contains ALL Excel line types.
I'll focus on just preserving the Excel line types during opening and re-saving. The rest are different issues that should be handled in different bugs (due to the larger scope of the whole border line issues). And the dashed line becomes hairline on resave. Those 2 are the only issues I see. Kohei Yoshida committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6d5270dab5c8ea8bae1ac3462aa5f6768f7d2c8f fdo#75130: Move these tests to the export test and test their export. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Kohei Yoshida committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1c1f42fdbad774cae7c45a7f8d60b9af766dee0a fdo#75130: Export cell borders to xls and xlsx correctly. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. 4.2 backport request: https://gerrit.libreoffice.org/8147 Not only single line, Dots, dash and Long Dash of 0.05 thick are not saved when exported to XLS also dash of 0.75 is not saved dots and dash of 1.75 and 2.5 thickness are saved as single line of 1.75 and 2.5 In import from XLS only Dash Dot Dash and Dot Dot Dash are not imported properly (are imported as single line 0.75 thick). We cannot expect calc to import it as such since the two formats are not supported in Calc. However instead of single line 0.75 thick, it could have been imported as dashes. I don't know if I should be asking this, but can border styles/thickness not supported by Excel be made to hide from the border menu when the file save type is XLS or if the file opened is XLS (In reply to comment #16) > I don't know if I should be asking this, but can border styles/thickness not > supported by Excel be made to hide from the border menu when the file save > type is XLS or if the file opened is XLS Please don't do this here. Focus on the bug reported. (In reply to comment #15) > Not only single line, Dots, dash and Long Dash of 0.05 thick are not saved > when exported to XLS also dash of 0.75 is not saved > dots and dash of 1.75 and 2.5 thickness are saved as single line of 1.75 and > 2.5 > > In import from XLS only Dash Dot Dash and Dot Dot Dash are not imported > properly (are imported as single line 0.75 thick). We cannot expect calc to > import it as such since the two formats are not supported in Calc. However > instead of single line 0.75 thick, it could have been imported as dashes. Don't mix multiple issues please. As I said in Comment 10 which I repeat here "I'll focus on just preserving the Excel line types during opening and re-saving. The rest are different issues that should be handled in different bugs (due to the larger scope of the whole border line issues)." Other issues such as missing border types MUST be handled separately from this bug. Thanks for your corporation. And just be upfront, those line types that we don't currently support will NOT be retained when re-saving to Excel. They will become solid lines for now. When we have a chance to support those missing line types, those types will be saved back to Excel intact. Kohei Yoshida committed a patch related to this issue. It has been pushed to "libreoffice-4-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d6d06b230bf923492c4a6ff42781cca25a28ef25&h=libreoffice-4-2 fdo#75130: Export cell borders to xls and xlsx correctly. It will be available in LibreOffice 4.2.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I know we still have a lot of work to be done on borders. These things take time and we can only do it one at a time. Fixed. *** Bug 75143 has been marked as a duplicate of this bug. *** Kohei Yoshida committed a patch related to this issue. It has been pushed to "libreoffice-4-2-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a09cedbcea86e0af0db1ced6df6cf95ab5ba946b&h=libreoffice-4-2-2 fdo#75130: Export cell borders to xls and xlsx correctly. It will be available already in LibreOffice 4.2.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 75546 has been marked as a duplicate of this bug. *** *** Bug 75638 has been marked as a duplicate of this bug. *** *** Bug 52578 has been marked as a duplicate of this bug. *** *** Bug 76533 has been marked as a duplicate of this bug. *** *** Bug 76547 has been marked as a duplicate of this bug. *** Created attachment 101453 [details]
screenshot, LiO v 4.2.4.2 (same applies for 4.2.5.2)
Created attachment 101454 [details]
screenshot, LiO v 4.2.4.2 (same applies for 4.2.5.2)
Versions 4.2.4 and 4.2.5 (maybe 4.2.3) are turning solid outline of the cell thinner than 0,75pt into dot outline when exporting in excel .xls or .xlsx
Not sure if it's a bug or a feature but assuming that you can't (in easy way at least) set the default thickness of outline once for every new created document, this behaviour is kind of very annoying
Here's the screenshot of what I'm talking about
(In reply to comment #31) @Alex: > Versions 4.2.4 and 4.2.5 (maybe 4.2.3) are turning solid outline of the cell > thinner than 0,75pt into dot outline when exporting in excel .xls or .xlsx For this behaviour you mentioned above, I have already filed a bug report: Bug 79787 - Normal cell borders are showing dashed/dotted when export to xlsx/xls and reopen in MSO I add it to SEE ALSO of this bug. However, for this bug (75130), it had been UNCONFIRMED->NEW->RESOLVED-FIXED. Althrough the issue you mentioned may be related, I don't think you should set this back to UNCONFIRMED. I'll add you to bug 79787 cc list, and I am setting this one back to RESOLVED FIXED |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.