Bug 7519

Summary:	Suspicious code in xf86ExtendedInitInt10
Product:	xorg	Reporter:	Ian Romanick <idr>
Component:	Server/General	Assignee:	Xorg Project Team <xorg-team>
Status:	RESOLVED FIXED	QA Contact:	Xorg Project Team <xorg-team>
Severity:	minor
Priority:	high
Version:	git
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	10101

Description Ian Romanick 2006-07-13 16:17:16 UTC

The BUS_ISA case in xf86ExtendedInitInt10 (hw/xfree86/int10/generic.c, line 220)
seems suspicious.  bios_location gets set to bios.location.legacy regardless of
the value of bios.location.legacy.  However, a different message is printed if
bios.location.legacy is zero.

In addition, in the case where _PC is not defined (line 315), bios_location is
only over-ridden when bios.location.legacy is non-zero.

This is suspicious, and I suspect that the code at line 220 is wrong.  If it is
correct, can anybody explain why?

Comment 1 Daniel Stone 2007-02-27 01:32:55 UTC

Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.

Comment 2 Adam Jackson 2008-02-29 12:28:50 UTC

The BiosLocation option is gone now, so I think this is moot.  ISA devices had better have their ROM at 0xc0000 or else.

ISA support is effectively dead in 1.5 anyway.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.