Bug 76579

Summary:	[swrast] piglit glean fbo regression
Product:	Mesa	Reporter:	Vinson Lee <vlee>
Component:	Other	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	brianp, chrisf
Version:	git	Keywords:	regression
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Vinson Lee 2014-03-25 01:18:10 UTC

mesa: 7683fce8781ef0169333c5ee1276392d058cfaa8 (master 10.2.0-devel)

$ ./bin/glean -t fbo --quick
GL_EXT_framebuffer_object is supported
GL_ARB_framebuffer_object is supported
FAILURE: All any buffer named by glDrawBuffers is missing, status should be GL_FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER_EXT (at tfbo.cpp:1322)
fbo:  FAIL rgba8, db, z24, s8, win+pmap, id 33
	5 tests passed, 1 tests failed.

a419a1c5654ac4a4a46ec3a80d75926e26919c99 is the first bad commit
commit a419a1c5654ac4a4a46ec3a80d75926e26919c99
Author: Chris Forbes <chrisf@ijw.co.nz>
Date:   Sun Mar 23 22:41:28 2014 +1300

    mesa: Generate FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT earlier
    
    The ARB_framebuffer_object spec lists this case before the
    FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER and
    FRAMEBUFFER_INCOMPLETE_READ_BUFFER cases.
    
    Fixes two broken cases in piglit's fbo-incomplete test, if
    ARB_ES2_compatibility is not advertised. (If it is, this is masked
    because the FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER /
    FRAMEBUFFER_INCOMPLETE_READ_BUFFER cases are removed by that extension)
    
    Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>
    Reviewed-by: Brian Paul <brianp@vmware.com>

:040000 040000 cb5fa6fcaea7036f0792067e35567f9cc4147151 5b463f68f58afde0fed387526158acf0fd1fc26b M	src
bisect run success

Comment 1 Chris Forbes 2014-03-25 01:55:16 UTC

I believe the glean test is wrong.

The completeness conditions are listed in this order in EXT_framebuffer_object, ARB_framebuffer_object, and the core spec.

I'm not sure there's much point to keeping glean's fbo tests -- piglit's native fbo tests are pretty thorough now.

If we do keep them though, I propose changing the FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER and FRAMEBUFFER_INCOMPLETE_READ_BUFFER tests to have one attachment, but not the one named by glDrawBuffer. I can send a patch for this.

Comment 2 Chris Forbes 2014-03-25 05:53:52 UTC

Patch as promised:

http://lists.freedesktop.org/archives/piglit/2014-March/010089.html

Comment 3 Chris Forbes 2014-03-31 20:11:50 UTC

Fixed in master as of 173b7b797c

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.