Bug 76580

Summary: [Bisected]igt/drv_suspend aborted
Product: DRI Reporter: lu hua <huax.lu>
Component: DRM/IntelAssignee: Daniel Vetter <daniel>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: major    
Priority: high CC: intel-gfx-bugs
Version: unspecified   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
dmesg none

Description lu hua 2014-03-25 05:11:58 UTC
Created attachment 96339 [details]
dmesg

System Environment:
--------------------------
Platform: Haswell
Kernel: drm-intel-fixes/0f4706d2740f2a221cd502922b22e522009041d9

Bug detailed description:
-----------------------------
It fails on all platforms with igt master branch.

Bisect shows: a388f3b98f039403a4583748db980d4a44dd6748 is the first bad commit.
commit a388f3b98f039403a4583748db980d4a44dd6748
Author:     Daniel Vetter <daniel.vetter@ffwll.ch>
AuthorDate: Sat Mar 22 13:22:11 2014 +0100
Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Sat Mar 22 14:28:03 2014 +0100

    lib: allow igt_skip_on_simulation outside of fixtures.

    Thomas noticed that in simulation mode a lot of the tests fall over
    instead of skipping properly. This is due to recently added
    self-checks which ensure that any call to igt_skip happens either
    within a fixture or subtest block (or it's a simple test without
    subtests). This is to catch bugs since pretty much always not wrapping
    up hardware setup and checks into these blocks is a bug.

    Bug simulation skipping is a bit different, so allow that exception.
    Otherwise we'd need to fix up piles of tests (and likely need to play
    a game of whack-a-mole).

    Also add a library testcase for all the different variants to make
    sure it really works.

    Cc: Thomas Wood <thomas.wood@intel.com>
    Cc: Ben Widawsky <benjamin.widawsky@intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>


run ./drv_suspend --run-subtest debugfs-reader
output:
IGT-Version: 1.6-g7a81094 (x86_64) (Linux: 3.14.0-rc5_drm-intel-fixes_0f4706_20140323+ x86_64)
rtcwake: wakeup from "mem" using /dev/rtc0 at Tue Mar 25 18:05:04 2014
Subtest debugfs-reader: SUCCESS
drv_suspend: igt_core.c:624: igt_fail: Assertion `!test_with_subtests || in_fixture' failed.
Aborted (core dumped)
Comment 1 Daniel Vetter 2014-03-26 14:40:45 UTC
Oops, should be fixed again with

commit 71c6f87eb3dacffbd489c83acfe95baf613d20cb
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Wed Mar 26 15:09:23 2014 +0100

    lib/igt_core: fix igt_skip_on_simulation regression
Comment 2 lu hua 2014-03-27 03:32:29 UTC
Verified.Fixed.
Comment 3 Elizabeth 2017-10-06 14:39:05 UTC
Closing old verified.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.