| Summary: | core: bus_exec_context_set_transient_property: Environment transient file is totally broken in most cases | ||
|---|---|---|---|
| Product: | systemd | Reporter: | Hristo Venev <hristo> |
| Component: | general | Assignee: | systemd-bugs |
| Status: | RESOLVED FIXED | QA Contact: | systemd-bugs |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Please submit patches to the mailing list, not to Bugzilla. Please ignore the patch and fix the bug. Bump. I'm not convinced this is a bug. systemd-run's --setenv option is documented to correspond to setting Environment= in the transient unit file. This means it uses the same syntax [1], too. Given that you're trying to assign a value with spaces, I believe you want this: systemd-run --setenv '"a=b c"' true Your suggestion would change the effect of multiple settings, which we support in cases like this: systemd-run --setenv 'a=b c=d' true With strv_join(), it would be: Environment=a=b c=d With strv_join_quoted(), it would be: Environment="a=b c=d" So, strv_join_quoted() would result in, I think, $a being set to "b c=d". If I'm wrong about breaking multiple environment settings, please re-open, and I'll take another look. [1] http://www.freedesktop.org/software/systemd/man/systemd.exec.html#Environment= David, it's actually OK to submit patches via fdo bugzilla. We support both ways. I think Hristo has a point, this is a bug. Reopening. Applied to git! Thanks! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
In most cases the generated file will not even be valid. Example: systemd-run --setenv 'a=b c' true This will yield the following file: [Service] Environment=a=b c Invalid environment assignment, ignoring: a=b c --- a/src/core/dbus-execute.c +++ b/src/core/dbus-execute.c @@ -842,7 +842,7 @@ strv_free(c->environment); c->environment = e; - joined = strv_join(c->environment, " "); + joined = strv_join_quoted(c->environment); if (!joined) return -ENOMEM;