Bug 77134

Summary:	If udisks_object_manager_client_new_for_bus_sync() fails, invalid access in udisks_client_finalize()
Product:	udisks	Reporter:	Stef Walter <stefw>
Component:	general	Assignee:	David Zeuthen (not reading bugmail) <zeuthen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Stef Walter 2014-04-07 11:12:06 UTC

In udisksclient.c: When this code fails:

  client->object_manager = udisks_object_manager_client_new_for_bus_sync (G_BUS_TYPE_SYSTEM,
                                                                          G_DBUS_OBJECT_MANAGER_CLIENT_FLAGS_NONE,
                                                                          "org.freedesktop.UDisks2",
                                                                          "/org/freedesktop/UDisks2",
                                                                          cancellable,
                                                                          &client->initialization_error);
  if (client->object_manager == NULL)
    goto out;

Then this aborts:

  g_signal_handlers_disconnect_by_func (client->object_manager,
                                        G_CALLBACK (on_object_added),
                                        client);

Along with the lines following it.

Comment 1 Martin Pitt 2015-01-13 15:15:15 UTC

Thanks, well spotted! Fixed in http://cgit.freedesktop.org/udisks/commit/?id=b4cdfc

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.