Bug 77139

Summary:	[next] remove dbus-glib GTypes from public API: low-hanging ones
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	tp-glib	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	xclaesse
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	76369

Description Simon McVittie 2014-04-07 15:03:53 UTC

+++ This bug was initially created as a clone of Bug #76369 +++

We should make sure that dbus-glib isn't exposed in our high-level API.

This is a start. Of the things in Bug #76369, I covered:


TpAccount:connection-error-details is an a{sv}. TpAccount::status-changed contains the same.

tp_capabilities_get_channel_classes returns a{sv}s. TpCapabilities:channel-classes is the same.

TpCapabilities:channel-classes (but it also has channel-classes-variant)


tp_connection_manager_param_get_default has a parallel GVariant version already, so it can probably be deleted.

Unrelated, but handle.h should talk about entity types, not handle types.

tp_message_set takes a GValue.

tp_account_get_avatar_finish() returns a GArray<guchar> which is OK but a bit odd.

TpChannelDispatchOperation:cdo-properties

TpChannel:channel-properties

TpChannel::group-members-changed (the details)

TpObserveChannelContext:observer-info

TpTextChannel:message-types (would be OK with a different GType)

TpAccountRequest:avatar is a GArray of undocumented type (by inspection: GArray<guchar>, which is a bit weird and a GBytes would probably be better).

Comment 1 Simon McVittie 2014-04-07 16:43:46 UTC

telepathy-glib: http://cgit.freedesktop.org/~smcv/telepathy-glib/log?h=next-gvariant1

MC: http://cgit.freedesktop.org/~smcv/telepathy-mission-control/log?h=next-gvariant1

Gabble: http://cgit.freedesktop.org/~smcv/telepathy-gabble/log?h=next-handle-type
Haze: http://cgit.freedesktop.org/~smcv/telepathy-haze/log?h=next-handle-type
Idle: http://cgit.freedesktop.org/~smcv/telepathy-idle/log?h=next-handle-type
Rakia: http://cgit.freedesktop.org/~smcv/telepathy-rakia/log?h=next-handle-type
Salut: http://cgit.freedesktop.org/~smcv/telepathy-salut/log?h=next-handle-type

Folks: no changes needed
TPAW: http://cgit.freedesktop.org/~smcv/telepathy-account-widgets/log?h=next-gvariant1
Empathy: http://cgit.freedesktop.org/~smcv/telepathy-account-widgets/log?h=next-gvariant1 (+ update to that TPAW version)

UOA changes untested, as usual.

Empathy largely untested due to lack of automated tests; smoke-testing it now.

Comment 2 Simon McVittie 2014-04-07 17:32:24 UTC

(In reply to comment #1)
> telepathy-glib:
> http://cgit.freedesktop.org/~smcv/telepathy-glib/log?h=next-gvariant1

The end result was OK, but some commits were weird due to interactive rebase going wrong. Please refresh to get 78261fa55155d7916a56d5f315f661ad683875af which fixes that.

Comment 3 Simon McVittie 2014-04-08 19:33:54 UTC

Fixed in git for 0.99.11. Some commits to core CMs (Bug #77200), MC (Bug #77199), Folks <https://bugzilla.gnome.org/show_bug.cgi?id=708871>, Empathy <https://bugzilla.gnome.org/show_bug.cgi?id=727043> were pushed unreviewed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.