Bug 77397

Summary:	bash completion
Product:	systemd	Reporter:	dankilman
Component:	general	Assignee:	systemd-bugs
Status:	RESOLVED FIXED	QA Contact:	systemd-bugs
Severity:	normal
Priority:	medium	CC:	tixxdz
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Proposed patch

Description dankilman 2014-04-13 12:39:27 UTC

the bash-completion for `systemctl` has a bug where `__get_startable_units` is searching for `$c == "failed "` instead of `$c == "failed"` (notice the space after the word `failed`).

I would open a pull request if this was github but i'm not really sure what the process for code contribution is around here.

Comment 1 Djalal Harouni 2014-04-13 14:47:45 UTC

Hi,

You can submit a quick patch to the mailing list:
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Thanks

Comment 2 Djalal Harouni 2014-04-13 15:06:20 UTC

Oh you can also submit a patch here!

Thanks

Comment 3 dankilman 2014-04-13 15:10:46 UTC

Created attachment 97311 [details] [review]
Proposed patch

Comment 4 Zbigniew Jedrzejewski-Szmek 2014-04-13 15:41:25 UTC

Applied as http://cgit.freedesktop.org/systemd/systemd/commit/?id=a163b64.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.