Summary: | "make install" does not create the startup links for /etc/init.d/xprint | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | xprint | Reporter: | Roland Mainz <roland.mainz> | ||||||
Component: | Other | Assignee: | Roland Mainz <roland.mainz> | ||||||
Status: | RESOLVED WONTFIX | QA Contact: | |||||||
Severity: | critical | ||||||||
Priority: | high | CC: | dparsons, eich | ||||||
Version: | unspecified | ||||||||
Hardware: | All | ||||||||
OS: | Linux (All) | ||||||||
Whiteboard: | |||||||||
i915 platform: | i915 features: | ||||||||
Attachments: |
|
Description
Roland Mainz
2004-06-21 01:30:45 UTC
... Created attachment 469 [details] [review] Patch for 2004-07-12-trunk (work-in-progress) Attachment attachment 469 [details] [review] checked-in... /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.90; previous revision: 1.89 /cvs/xorg/xc/programs/Xserver/Xprint/etc/init.d/Imakefile,v <-- Imakefile new revision: 1.3; previous revision: 1.2 ... leaving bug open for now until we figured-out a solution to do this in a LSB-compilant way (right now the LSB script to create links for /etc/init.d scripts only works as user "root" and only changes links in /etc/init./, not relative to a given base dir... ;-(( ). Created attachment 471 [details] [review] Patch for 2004-07.13-trunk to fix "make install" bustage on Linux attachment 471 [details] [review] checked-in: /cvs/xorg/xc/programs/Xserver/Xprint/etc/init.d/Imakefile,v <-- Imakefile new revision: 1.4; previous revision: 1.3 Someone on IRC pointed out that /usr/lib/lsb/install_initd accepts no-/etc paths, too - which means we could simply use... -- snip -- /usr/lib/lsb/install_initd $(DESTDIR)/etc/init.d/xprint -- snip -- ...on LSB-compilant Linux distributions. sndirsch/egbert: Is this a non-standard feature of the SuSE version of /usr/lib/lsb/install_initd or is that supported by all LSB implementations ? Roland, I can't comment on LSB as I'm not an expert in this area, but for SuSE Linux it's sufficient to install a init script to /etc/init.d and to call "insserv -d <scripname>" after this, which will create the according symlinks depending on the definitions in the header of the script. Your xprint script already has such a header. I'm already calling insserv in the %post of SuSE's next xorg-x11-Xprt package and it seems to work fine. Sorry I didn't comment on this earlier. Debian has a standard tool for setting up the links: update-rc.d. It's invoked in the installation scripts (postinst, etc). To make my life even easier, we have a commonly used debhelper tool, (dh_installinit), which places the code into postinst automatically when I create the binary deb files. update-rc.d is provided by the sysvinit package. Looks like building xprint is no longer possible. ==> WONTFIX |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.