Bug 77702

I think the test is incorrect.  

Section 10.10 (Conditional Rendering) of the OpenGL 4.4 spec says:

    "If the result (SAMPLES_PASSED) of the query is zero, or if the
    result (ANY_SAMPLES_PASSED or ANY_SAMPLES_PASSED_CONSERVATIVE)
    is false, all rendering commands described in section 2.4 are
    discarded and have no effect when issued between
    BeginConditionalRender and the corresponding EndConditionalRender."

Section 2.4 (Rendering Commands) says:

    "Such commands are called rendering commands, and include the
    drawing commands *Draw* (see section 10.5), as well as these
    additional commands:

        • BlitFramebuffer (see section 18.3.1)
        • Clear (see section 17.4.3)
        • ClearBuffer* (see section 17.4.3.1)
        • DispatchCompute* (see section 19)"

It would have been much better to have these spec references in the commit message and the in-code comments than the reference that is there.  Oh well.

Out of curiosity... Does this test pass as-is on NVIDIA or AMD?

I have tested it in my laptop (with Optimus and the proprietary driver) and it failed:

$ optirun ./bin/nv_conditional_render-blitframebuffer -auto
Probe color at (0,16)
  Expected: 0.000000 1.000000 0.000000 0.000000
  Observed: 1.000000 0.000000 0.000000 0.000000
PIGLIT: {'result': 'fail' }

Info about my system:

OpenGL vendor string: NVIDIA Corporation
OpenGL renderer string: NVS 4200M/PCIe/SSE2
OpenGL core profile version string: 4.3.0 NVIDIA 331.49
OpenGL core profile shading language version string: 4.30 NVIDIA via Cg compiler

Probe color at (0,0)
  Expected: 0.000000 1.000000 0.000000 0.000000
  Observed: 1.000000 0.000000 0.000000 0.000000
PIGLIT: {'result': 'fail' }

Also on r600g it fails (mesa-git, kernel 3.15-git, HD 6550)

Fixed the piglit test case with this commit. Now, test passes on mesa master with i965 drivers:

commit 0364f161c9b41b7b1fe94f7b761241ccfdca4981
Author: Anuj Phogat <anuj.phogat@gmail.com>
Date:   Fri Apr 25 16:35:34 2014 -0700

    Fix expected behavior of glBlitFramebuffer() with conditional rendering
    
    It is clarified on page 679 of OpenGL 4.4 core profile spec:
       "Added BlitFramebuffer to commands affected by conditional
        rendering in section 10.10 (Bug 9562)."
    
    This addition is also made to OpenGL 4.4 compatibility profile spec.
    
    Tests the bug fix made in mesa commits 1d350b9 and 8ed42dd:
    "i965: Add glBlitFramebuffer to commands affected by conditional
    rendering"
    
    Previous to this patch, this test fail on NVIDIA 4200M (driver
    version 331.49), as reported by Samuel Iglesias.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77702
    Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
    Tested-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
    Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>

Verified.Fixed.