Bug 77865

Some of these are probably due to missing stencil stuff.  CC'ing Topi.

Oh, this got fixed a while back as well.

The segfault goes away, but they still fail.

run ./GTF -width=64 -height=64 -run=GL3Tests/framebuffer_blit/framebuffer_blit_functionality_all_buffer_blit.test

Skipping ConfigID: 82 Sample Buffers: 1 Samples: 4
Skipping ConfigID: 84 Sample Buffers: 1 Samples: 8
Skipping ConfigID: 86 Sample Buffers: 1 Samples: 4
Skipping ConfigID: 88 Sample Buffers: 1 Samples: 8
Conformance FAILED 5 of 6 tests.
Test duration: 1s

Created attachment 100437 [details]
output

These are all working for me, as of:

commit 49659ad90c501ae584b7d76ca98f35a8f57d40fe
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Fri Jun 13 15:26:40 2014 -0700

    i965: Use 8x4 aligned rectangles for HiZ operations on Broadwell.
    
    Like on Haswell, we need to use 8x4 aligned rectangle primitives for
    hierarchical depth buffer resolves and depth clears.  See the comments
    in brw_blorp.cpp's brw_hiz_op_params() constructor.  (The Broadwell
    documentation confirms that this is still necessary.)
    
    This patch makes the Broadwell code follow the same behavior as Chad and
    Jordan's Gen7 BLORP code.  Based on a patch by Topi Pohjolainen.
    
    This fixes es3conform's framebuffer_blit_functionality_scissor_blit
    test, with no Piglit regressions.
    
    Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
    Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
    Cc: "10.2" <mesa-stable@lists.freedesktop.org>

Can you retest?  Thanks!

Created attachment 101216 [details]
output(39cdf1621)

(In reply to comment #5)
> These are all working for me, as of:
> 
> commit 49659ad90c501ae584b7d76ca98f35a8f57d40fe
> Author: Kenneth Graunke <kenneth@whitecape.org>
> Date:   Fri Jun 13 15:26:40 2014 -0700
> 
>     i965: Use 8x4 aligned rectangles for HiZ operations on Broadwell.
>     
>     Like on Haswell, we need to use 8x4 aligned rectangle primitives for
>     hierarchical depth buffer resolves and depth clears.  See the comments
>     in brw_blorp.cpp's brw_hiz_op_params() constructor.  (The Broadwell
>     documentation confirms that this is still necessary.)
>     
>     This patch makes the Broadwell code follow the same behavior as Chad and
>     Jordan's Gen7 BLORP code.  Based on a patch by Topi Pohjolainen.
>     
>     This fixes es3conform's framebuffer_blit_functionality_scissor_blit
>     test, with no Piglit regressions.
>     
>     Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
>     Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
>     Cc: "10.2" <mesa-stable@lists.freedesktop.org>
> 
> Can you retest?  Thanks!

Test on latest master branch(commit 39cdf1621efaebcefc74403b0ef8fa1f699e4b97), they still fail.

Oops.  They worked for me with -minfmt, but not with the default options.

This patch should fix it:
http://lists.freedesktop.org/archives/mesa-dev/2014-June/061825.html

(In reply to comment #7)
> Oops.  They worked for me with -minfmt, but not with the default options.
> 
> This patch should fix it:
> http://lists.freedesktop.org/archives/mesa-dev/2014-June/061825.html

Fixed by this patch.

Fixed by:

commit a20994d61677adea7f15facbc6bb025f32b37c93
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Wed Jun 18 22:25:33 2014 -0700

    i965: Save meta stencil blit programs in the context.
    
    When the last context in a share group is destroyed, the hash table
    containing all of the shader programs (ctx->Shared->ShaderObjects) is
    destroyed, throwing away all of the shader programs.
    
    Using a static variable to store program IDs ends up holding on to them
    after this, so we think we still have a compiled program, when it
    actually got destroyed.  _mesa_UseProgram then hits GL errors, since no
    program by that ID exists.
    
    Instead, store the program IDs in the context, so we know to recompile
    if our context gets destroyed and the application creates another one.
    
    Fixes es3conform tests when run without -minfmt (where it creates
    separate contexts for testing each visual).
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77865
    Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
    Reviewed-by: Eric Anholt <eric@anholt.net>
    Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
    Cc: "10.2" <mesa-stable@lists.freedesktop.org>

Verified.Fixed.