Bug 7876

Summary:

Xserver crash when using appgroups

Product:

xorg

Reporter:

Rich Coe <Richard.Coe>

Component:

Server/General

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

high

Keywords:

patch

Version:

7.0 (2005.12)

Hardware:

x86 (IA32)

OS:

Linux (All)

Whiteboard:

i915 platform:

i915 features:

Bug Depends on:

Bug Blocks:

6666

Attachments:

Description	Flags
xc/programs/Xserver/os/connection.c.patch	none

Description Rich Coe 2006-08-14 14:20:32 UTC

This is a follow up to bug 6956.

When shutting down apps in an appgroup, its possible to crash the Xserver.
I don't know if this is dependent on a busy host or not.

A for-loop in CheckConnections() uses a local copy of the select file descriptor
list, which can change when an appgroup is shutting down.

The attached patch checks for a valid ConnectionTranslation entry prior
to calling CloseDownClient() with a null value.

Comment 1 Rich Coe 2006-08-14 14:22:35 UTC

Created attachment 6550 [details] [review]
xc/programs/Xserver/os/connection.c.patch

Comment 2 Daniel Stone 2006-11-08 08:04:38 UTC

committed to master and server 1.2 branch, thanks a bunch

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.