| Summary: | [HSW/BDW]igt/kms_flip subcases bo-too-big-interruptible and bo-too-big cause system hang | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | DRI | Reporter: | Guo Jinxian <jinxianx.guo> | ||||||
| Component: | DRM/Intel | Assignee: | Daniel Vetter <daniel> | ||||||
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||
| Severity: | normal | ||||||||
| Priority: | medium | CC: | intel-gfx-bugs, yi.sun | ||||||
| Version: | unspecified | ||||||||
| Hardware: | Other | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| i915 platform: | i915 features: | ||||||||
| Attachments: |
|
||||||||
|
Description
Guo Jinxian
2014-05-20 02:24:08 UTC
commit 19656430a874132a1d79c56387a6eec1ef9a5689 Author: Oscar Mateo <oscar.mateo@intel.com> Date: Fri May 16 14:20:43 2014 +0100 drm/i915: Gracefully handle obj not bound to GGTT in is_pin_display Otherwise, we do a NULL pointer dereference. I've seen this happen while handling an error in i915_gem_object_pin_to_display_plane(): If i915_gem_object_set_cache_level() fails, we call is_pin_display() to handle the error. At this point, the object is still not pinned to GGTT and maybe not even bound, so we have to check before we dereference its GGTT vma. The IGT kms_flip/bo-too-big tests for this bug. v2: Chris Wilson says restoring the old value is easier, but that is_pin_display is useful as a theory of operation. Take the solomonic decision: at least this way is_pin_display is a little more robust (until Chris can kill it off). v3: Chris suggests the WARN in i915_gem_obj_to_ggtt has outlived its usefulness: add a reminder to remove it. Issue: VIZ-3772 Signed-off-by: Oscar Mateo <oscar.mateo@intel.com> Testcase: igt/kms_flip/bo-too-big Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Verified ---------------------- [root@x-bdw opt]# ./kms_flip --run-subtest bo-too-big IGT-Version: 1.6-gff3c122 (x86_64) (Linux: 3.15.0-rc6_drm-intel-nightly_c37f30_20140526+ x86_64) Using monotonic timestamps Beginning bo-too-big on crtc 5, connector 14 1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780 Beginning bo-too-big on crtc 8, connector 14 1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780 Beginning bo-too-big on crtc 11, connector 14 1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780 Subtest bo-too-big: SUCCESS Created attachment 99916 [details]
dmesg
This bug still be able to reproduce on latest -fixes(c1240bd2842f6ec26d7dc1d9c845a197a41d33fe) on BDW and IVB.
Output:
./kms_flip --run-subtest bo-too-big
IGT-Version: 1.6-gff3c122 (x86_64) (Linux: 3.15.0-rc5_drm-intel-fixes_c1240b_20140527+ x86_64)
Using monotonic timestamps
Beginning bo-too-big on crtc 5, connector 14
1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
-fixes should have moved forward now. Test passed on latest -nightly(1087d4bf01e79523898c6c31615bf0c369e0039a) Output: [root@x-hsw27 tests]# time ./kms_flip --run-subtest bo-too-big IGT-Version: 1.7-g7ef5372 (x86_64) (Linux: 3.16.0-rc2_drm-intel-nightly_1087d4_20140627+ x86_64) Using monotonic timestamps Beginning bo-too-big on crtc 6, connector 16 1280x1024 60 1280 1328 1440 1688 1024 1025 1028 1066 0x5 0x48 108000 Beginning bo-too-big on crtc 10, connector 16 1280x1024 60 1280 1328 1440 1688 1024 1025 1028 1066 0x5 0x48 108000 Beginning bo-too-big on crtc 14, connector 16 1280x1024 60 1280 1328 1440 1688 1024 1025 1028 1066 0x5 0x48 108000 Subtest bo-too-big: SUCCESS real 0m0.431s user 0m0.038s sys 0m0.024s [root@x-hsw27 tests]# time ./kms_flip --run-subtest bo-too-big-interruptible IGT-Version: 1.7-g7ef5372 (x86_64) (Linux: 3.16.0-rc2_drm-intel-nightly_1087d4_20140627+ x86_64) Using monotonic timestamps Beginning bo-too-big-interruptible on crtc 6, connector 16 1280x1024 60 1280 1328 1440 1688 1024 1025 1028 1066 0x5 0x48 108000 Beginning bo-too-big-interruptible on crtc 10, connector 16 1280x1024 60 1280 1328 1440 1688 1024 1025 1028 1066 0x5 0x48 108000 Beginning bo-too-big-interruptible on crtc 14, connector 16 1280x1024 60 1280 1328 1440 1688 1024 1025 1028 1066 0x5 0x48 108000 Subtest bo-too-big-interruptible: SUCCESS real 0m0.393s user 0m0.037s sys 0m0.021s The result on latest -fixes(8525a235c96a548873c6c5644f50df32b31f04c6) was passed too. Output: [root@x-hsw27 tests]# time ./kms_flip --run-subtest bo-too-big-interruptible IGT-Version: 1.7-g7ef5372 (x86_64) (Linux: 3.16.0-rc2_drm-intel-fixes_8525a2_20140626+ x86_64) Using monotonic timestamps Beginning bo-too-big-interruptible on crtc 5, connector 13 1280x1024 60 1280 1328 1440 1688 1024 1025 1028 1066 0x5 0x48 108000 Beginning bo-too-big-interruptible on crtc 8, connector 13 1280x1024 60 1280 1328 1440 1688 1024 1025 1028 1066 0x5 0x48 108000 Beginning bo-too-big-interruptible on crtc 11, connector 13 1280x1024 60 1280 1328 1440 1688 1024 1025 1028 1066 0x5 0x48 108000 Subtest bo-too-big-interruptible: SUCCESS real 0m0.329s user 0m0.044s sys 0m0.026s [root@x-hsw27 tests]# time ./kms_flip --run-subtest bo-too-big IGT-Version: 1.7-g7ef5372 (x86_64) (Linux: 3.16.0-rc2_drm-intel-fixes_8525a2_20140626+ x86_64) Using monotonic timestamps Beginning bo-too-big on crtc 5, connector 13 1280x1024 60 1280 1328 1440 1688 1024 1025 1028 1066 0x5 0x48 108000 Beginning bo-too-big on crtc 8, connector 13 1280x1024 60 1280 1328 1440 1688 1024 1025 1028 1066 0x5 0x48 108000 Beginning bo-too-big on crtc 11, connector 13 1280x1024 60 1280 1328 1440 1688 1024 1025 1028 1066 0x5 0x48 108000 Subtest bo-too-big: SUCCESS real 0m0.262s user 0m0.033s sys 0m0.022s Closing old verified+fixed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.