Bug 79054

Summary:

[SNB/HSW/BSW]igt/kms_flip some subcases fail

Product:

DRI

Reporter:

Guo Jinxian <jinxianx.guo>

Component:

DRM/Intel

Assignee:

Ville Syrjala <ville.syrjala>

Status:

CLOSED FIXED

QA Contact:

Intel GFX Bugs mailing list <intel-gfx-bugs>

Severity:

normal

Priority:

medium

CC:

intel-gfx-bugs, przanoni, yi.sun

Version:

unspecified

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
dmesg	none

Description Guo Jinxian 2014-05-22 06:18:58 UTC

Created attachment 99557 [details]
dmesg

==System Environment==
--------------------------
Regression: No. 
It's new case

Non-working platforms: HSW

==kernel==
--------------------------
-nightly: 36765340cb068dec1216342bfcdbf2678ec29860(fails)
-queued: bc76e320f21f8bd790a72bd5dc06909617432352(fails)
    Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue May 20 22:46:50 2014 +0200

    drm/i915: Drop now misleading DDI comment from dp_link_down

    Since

    commit 2e82a7203182d0883d0f9450d40ad6e1c6578ad9
    Author: Imre Deak <imre.deak@intel.com>
    Date:   Fri Jan 17 15:46:43 2014 +0200

        drm/i915: don't disable DP port after a failed link training

    and

    commit 5d6a1116c6475404e6505b708320f9579ae19acd
    Author: Imre Deak <imre.deak@intel.com>
    Date:   Thu Jan 16 18:35:57 2014 +0200

        drm/i915: don't disable the DP port if the link is lost

    we no longer call intel_dp_link_down from generic DP code, but only
    from the !HAS_DDI dp encoder functions. hsw/bdw have their own encoder
    disabling callback in intel_ddi.c.

    Hence the early return is no longer needed and the big comment just
    confusing, so let's rip it out. To ensure what we don't accidentally
    use this again on ddi encoders add a WARN_ON instead.

    Spotted while reading through intel_dp.c

    Cc: Imre Deak <imre.deak@intel.com>
    Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    
-fixes: 4ba4801d73d14690ed15774424e8b1d4c18323a5(fails)
    Author: Dave Airlie <airlied@redhat.com>
Date:   Tue May 20 09:56:26 2014 +1000

    Merge tag 'drm-intel-fixes-2014-05-16' of git://anongit.freedesktop.org/drm-intel into drm-fixes

    Intel fixes for regressions, black screens and hangs, for 3.15.

    * tag 'drm-intel-fixes-2014-05-16' of git://anongit.freedesktop.org/drm-intel:
      drm/i915: Increase WM memory latency values on SNB
      drm/i915: restore backlight precision when converting from ACPI
      drm/i915: Use the first mode if there is no preferred mode in the EDID
      drm/i915/dp: force eDP lane count to max available lanes on BDW
      drm/i915/vlv: reset VLV media force wake request register
      drm/i915/SDVO: For sysfs link put directory and target in correct order
      drm/i915: use lane count and link rate from VBT as minimums for eDP
      drm/i915: clean up VBT eDP link param decoding
      drm/i915: consider the source max DP lane count too

==Bug detailed description==
-----------------------------
igt/kms_flip some subcases below fail

igt/kms_flip/vblank-vs-dpms-rpm
igt/kms_flip/vblank-vs-dpms-rpm-interruptible
igt/kms_flip/vblank-vs-modeset-rpm
igt/kms_flip/vblank-vs-modeset-rpm-interruptible


Output:
./kms_flip --run-subtest vblank-vs-dpms-rpm
IGT-Version: 1.6-gc75dcbd (x86_64) (Linux: 3.15.0-rc5_drm-intel-nightly_367653_20140521+ x86_64)
Using monotonic timestamps
Beginning vblank-vs-dpms-rpm on crtc 5, connector 13
  1024x768 60 1024 1048 1184 1344 768 771 777 806 0xa 0x40 65000
.Test assertion failure function run_test_step, file kms_flip.c:941:
Last errno: 0, Success
Failed assertion: igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED)
Subtest vblank-vs-dpms-rpm: FAIL


==Reproduce steps==
---------------------------- 
1. ./kms_flip --run-subtest vblank-vs-dpms-rpm

Comment 1 Daniel Vetter 2014-05-22 06:28:26 UTC

The dpms subtests are a dupe of bug 78687

So lets only track vblank-vs-modeset-dpms(-interruptible) here. Can you please attach the output from that testcase?

Comment 2 Guo Jinxian 2014-05-22 06:50:59 UTC

(In reply to comment #1)
> The dpms subtests are a dupe of bug 78687
> 
> So lets only track vblank-vs-modeset-dpms(-interruptible) here. Can you
> please attach the output from that testcase?

./kms_flip --run-subtest vblank-vs-modeset-rpm
IGT-Version: 1.6-gc75dcbd (x86_64) (Linux: 3.15.0-rc5_drm-intel-nightly_367653_20140521+ x86_64)
Using monotonic timestamps
Beginning vblank-vs-modeset-rpm on crtc 5, connector 13
  1024x768 60 1024 1048 1184 1344 768 771 777 806 0xa 0x40 65000
.Test assertion failure function run_test_step, file kms_flip.c:941:
Last errno: 0, Success
Failed assertion: igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED)
Subtest vblank-vs-modeset-rpm: FAIL


./kms_flip --run-subtest vblank-vs-modeset-rpm-interruptible
IGT-Version: 1.6-gc75dcbd (x86_64) (Linux: 3.15.0-rc5_drm-intel-nightly_367653_20140521+ x86_64)
Using monotonic timestamps
Beginning vblank-vs-modeset-rpm-interruptible on crtc 5, connector 13
  1024x768 60 1024 1048 1184 1344 768 771 777 806 0xa 0x40 65000
.Test assertion failure function run_test_step, file kms_flip.c:941:
Last errno: 4, Interrupted system call
Failed assertion: igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED)
Subtest vblank-vs-modeset-rpm-interruptible: FAIL

Comment 3 Jesse Barnes 2014-06-25 22:38:20 UTC

I see this on my MBA.  Looks like the device never autosuspends as it should, so the test fails.

Comment 4 Jesse Barnes 2014-06-26 16:14:58 UTC

The dpms rpm tests fail as expected, vblank-vs-modeset-rpm passes on pipe a but fails on pipe b:

[root@jbarnes-mba tests]$ ./kms_flip --run-subtest vblank-vs-modeset-rpm
IGT-Version: 1.7-g7ef5372 (x86_64) (Linux: 3.16.0-rc2+ x86_64)
Using monotonic timestamps
Beginning vblank-vs-modeset-rpm on crtc 6, connector 17
  1440x900 60 1440 1504 1546 1652 900 903 909 926 0xa 0x48 91540
...
vblank-vs-modeset-rpm on crtc 6, connector 17: PASSED

Beginning vblank-vs-modeset-rpm on crtc 10, connector 17
  1440x900 60 1440 1504 1546 1652 900 903 909 926 0xa 0x48 91540
..Test assertion failure function check_state, file kms_flip.c:576:
Last errno: 0, Success
Failed assertion: es->current_seq - es->last_seq <= 100
unexpected vblank seq 11, should be < 115
Subtest vblank-vs-modeset-rpm: FAIL

Comment 5 Jesse Barnes 2014-06-26 16:29:34 UTC

Guo, note you need to enable runtime suspend by enabling it first:
echo auto > /sys/devices/pci0000\:00/0000\:00\:02.0/power/control

Some distros enable it, some don't.

Comment 6 Jesse Barnes 2014-06-26 16:33:26 UTC

Ville says his vblank series ought to address this, so I'll let him close this when it lands.

Comment 7 Guo Jinxian 2014-07-16 05:14:29 UTC

This bug still able to reproduce on latest -nightly(77820625217fa547586f00be7cae56e5c5e255bf)

./kms_flip --run-subtest vblank-vs-dpms-rpm
IGT-Version: 1.7-g8d60b82 (x86_64) (Linux: 3.16.0-rc5_drm-intel-nightly_778206_20140716+ x86_64)
Using monotonic timestamps
Beginning vblank-vs-dpms-rpm on crtc 7, connector 18
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
.Test assertion failure function run_test_step, file kms_flip.c:951:
Last errno: 0, Success
Failed assertion: igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED)
Subtest vblank-vs-dpms-rpm: FAIL

Comment 8 Guo Jinxian 2014-07-23 06:25:41 UTC

The bug still able to reproduce on latest -nightly(d62845db2ec40e15a76e5d5ebfe1a039ea2538c4)

[root@x-hsw24 tests]# ./kms_flip --run-subtest vblank-vs-dpms-rpm
IGT-Version: 1.7-g70e6ed9 (x86_64) (Linux: 3.16.0-rc6_drm-intel-nightly_d62845_20140723+ x86_64)
Using monotonic timestamps
Beginning vblank-vs-dpms-rpm on crtc 7, connector 17
  1920x1080 60 1920 2008 2052 2200 1080 1084 1089 1125 0x5 0x48 148500
.Test assertion failure function run_test_step, file kms_flip.c:951:
Failed assertion: igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED)
Subtest vblank-vs-dpms-rpm: FAIL

Comment 9 Jani Nikula 2014-08-26 12:40:38 UTC

Please retest with current drm-intel-nightly.

Comment 10 Guo Jinxian 2014-08-27 07:08:43 UTC

(In reply to comment #9)
> Please retest with current drm-intel-nightly.

Test still failed on latest -nihglty(c30b73ce7c138b5fd671ed3a7e1301bd273fd661)

[root@x-hsw24 tests]# ./kms_flip --run-subtest vblank-vs-dpms-rpm
IGT-Version: 1.7-g50166d2 (x86_64) (Linux: 3.17.0-rc2_drm-intel-nightly_c30b73_20140827+ x86_64)
Using monotonic timestamps
Beginning vblank-vs-dpms-rpm on crtc 8, connector 18
  1024x768 60 1024 1048 1184 1344 768 771 777 806 0xa 0x40 65000
.Test assertion failure function run_test_step, file kms_flip.c:951:
Failed assertion: igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED)
Subtest vblank-vs-dpms-rpm: FAIL

Comment 11 Guo Jinxian 2014-09-11 08:58:21 UTC

The failure is able to reproduce on latest -nihglty(72faa6a63351879b381bd9e4013f38bc94f11999) on BSW

[root@x-bsw01 tests]# ./kms_flip --run-subtest vblank-vs-dpms-rpm-interruptible
IGT-Version: 1.8-gd9d3f4b (x86_64) (Linux: 3.17.0-rc4_drm-intel-nightly_72faa6_20140911+ x86_64)
Using monotonic timestamps
Beginning vblank-vs-dpms-rpm-interruptible on crtc 8, connector 31
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
...Test assertion failure function run_test_step, file kms_flip.c:949:
Failed assertion: igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED)
Last errno: 4, Interrupted system call
Subtest vblank-vs-dpms-rpm-interruptible: FAIL (6.423s)

Comment 12 Guo Jinxian 2014-09-22 07:11:26 UTC

The failure is able to reproduce on SNB on latest -nightly(c5660b4ad395f1e34eacc22cf81c687edfc9c83c)


[root@x-sgb4 tests]# ./kms_flip --run-subtest vblank-vs-dpms-rpm-interruptible
IGT-Version: 1.8-g25c55d3 (i686) (Linux: 3.17.0-rc5_drm-intel-nightly_c5660b_20140922+ i686)
Using monotonic timestamps
Beginning vblank-vs-dpms-rpm-interruptible on crtc 8, connector 14
  1024x768 60 1024 1048 1184 1344 768 771 777 806 0xa 0x40 65000
..Test assertion failure function run_test_step, file kms_flip.c:949:
Failed assertion: igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED)
Last errno: 4, Interrupted system call
Subtest vblank-vs-dpms-rpm-interruptible: FAIL (0.405s)
[root@x-sgb4 tests]# ./kms_flip --run-subtest vblank-vs-modeset-rpm-interruptible
IGT-Version: 1.8-g25c55d3 (i686) (Linux: 3.17.0-rc5_drm-intel-nightly_c5660b_20140922+ i686)
Using monotonic timestamps
Beginning vblank-vs-modeset-rpm-interruptible on crtc 8, connector 14
  1024x768 60 1024 1048 1184 1344 768 771 777 806 0xa 0x40 65000
.Test assertion failure function run_test_step, file kms_flip.c:949:
Failed assertion: igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED)
Last errno: 4, Interrupted system call
Subtest vblank-vs-modeset-rpm-interruptible: FAIL (0.317s)

Comment 13 Paulo Zanoni 2014-10-27 16:03:36 UTC

We recently fixed some related kms_flip code, I believe this bug is fixed. Please retest this bug.

Comment 14 Guo Jinxian 2014-10-28 08:36:38 UTC

Test skips on latest fixes(6be1e3d3ea29354d7c834a3936e796e185d5c73b)


[root@x-hsw27 tests]# ./kms_flip --run-subtest vblank-vs-dpms-rpm
IGT-Version: 1.8-g15972aa (x86_64) (Linux: 3.18.0-rc2_drm-intel-fixes_6be1e3_20141028+ x86_64)
Test requirement not met in function drm_open_any_master, file drmtest.c:341:
Test requirement: drmSetMaster(fd) == 0
Can't become DRM master, please check if no other DRM client is running.
Last errno: 22, Invalid argument
Subtest vblank-vs-dpms-rpm: SKIP
[root@x-hsw27 tests]# ./kms_flip --run-subtest vblank-vs-dpms-rpm-interruptible
IGT-Version: 1.8-g15972aa (x86_64) (Linux: 3.18.0-rc2_drm-intel-fixes_6be1e3_20141028+ x86_64)
Test requirement not met in function drm_open_any_master, file drmtest.c:341:
Test requirement: drmSetMaster(fd) == 0
Can't become DRM master, please check if no other DRM client is running.
Last errno: 22, Invalid argument
Subtest vblank-vs-dpms-rpm-interruptible: SKIP
[root@x-hsw27 tests]# ./kms_flip --run-subtest vblank-vs-modeset-rpm-interruptible
IGT-Version: 1.8-g15972aa (x86_64) (Linux: 3.18.0-rc2_drm-intel-fixes_6be1e3_20141028+ x86_64)
Test requirement not met in function drm_open_any_master, file drmtest.c:341:
Test requirement: drmSetMaster(fd) == 0
Can't become DRM master, please check if no other DRM client is running.
Last errno: 22, Invalid argument
Subtest vblank-vs-modeset-rpm-interruptible: SKIP
[root@x-hsw27 tests]# ./kms_flip --run-subtest vblank-vs-modeset-rpm
IGT-Version: 1.8-g15972aa (x86_64) (Linux: 3.18.0-rc2_drm-intel-fixes_6be1e3_20141028+ x86_64)
Test requirement not met in function drm_open_any_master, file drmtest.c:341:
Test requirement: drmSetMaster(fd) == 0
Can't become DRM master, please check if no other DRM client is running.
Last errno: 22, Invalid argument
Subtest vblank-vs-modeset-rpm: SKIP

Comment 15 Elizabeth 2017-10-06 14:38:07 UTC

Closing old verified.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.