Bug 79156

Summary: Writer: Table cell Numbering Broken
Product: LibreOffice Reporter: reporter_of_bugs
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: NEW --- QA Contact:
Severity: minor    
Priority: high CC: jmadero.dev, mst.fdo, tymoteusz.jankowski
Version: 4.3.0.3 rcKeywords: bisected, regression
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
See Also: https://issues.apache.org/ooo/show_bug.cgi?id=124371
Whiteboard: bibisected
i915 platform: i915 features:

Description reporter_of_bugs 2014-05-23 22:01:53 UTC
1. Open a new writer doc, create a table 2x2

2. Select the cells, Press F12 and all cells are numbered '1.'

Expected behaviour: Cells will be numbered 1 to 2 Left to Right on Row 1, the 3 to 4 on Row 2 e.g

1. |2.
------
3. |4.

Actual behaviour: Cells are *all* numbered 1.

Additional info: 
a. selecting cells individually & pressing F12 will have numbering increment as normal.
b. If the bottom row of the table is selected and a new row inserted, each subsequent row increments *all* cell numbering in that row by one.
c. Numbering works as expected in Ubuntu 14.04 64bit 4.2.4.2 Build ID: 63150712c6d317d27ce2db16eb94c2f3d7b699f8
Comment 1 reporter_of_bugs 2014-05-23 22:03:00 UTC
Importance switched to high as this is a regression from 4.2.4.2
Comment 2 Joel Madero 2014-05-23 22:06:42 UTC
Ubuntu 14.04
LibreOffice 4.3 beta1
LibreOffice 4.2.4.2 release (works)


d97d068402198fd528087c954ff8bf7fc2380a77 is the first bad commit
commit d97d068402198fd528087c954ff8bf7fc2380a77
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date:   Mon May 12 01:37:21 2014 +0000

    source-hash-3d1b1eea83703919c43620f9adef05e5b24c4bed
    
    commit 3d1b1eea83703919c43620f9adef05e5b24c4bed
    Author:     Caolán McNamara <caolanm@redhat.com>
    AuthorDate: Wed Mar 19 12:27:07 2014 +0000
    Commit:     Caolán McNamara <caolanm@redhat.com>
    CommitDate: Wed Mar 19 15:37:56 2014 +0000
    
        coverity#735757 Unchecked dynamic_cast
    
        Change-Id: I268b9c4df81598f68b8da2c258d70c2118b69d82

:100644 100644 55e483c4a724436ee0e792f72b90a3d301c77064 46da6ac1f330f20bd0a4ebebe27910e2c0e49e49 M	ccache.log
:100644 100644 109c99441737bb49205950d8d26f994ab7ade8ca 88c019e4e1f3e2591ad255a84ebb468863e18b3f M	commitmsg
:100644 100644 489b61544cecbe2b2fc066ce04098712be6374d8 80fe30beee6868b7ef681d3d1040c51b252661ea M	make.log
:040000 040000 8d40ab0ff1362b98fa7646afb94a246acb54cd98 fe475bf82129a0a85c90230737d704d41ab77938 M	opt


# bad: [a92705c1fabafddd43d175a0714855cd22551232] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
# good: [6ab7f53af36f13bbefdd4e4fcbd3d1ea432a77d9] source-hash-22029c7e17b4cb48acb058d47ec9c3b6b8b6b294
git bisect start 'latest' 'oldest'
# good: [bebf9d31c8fe9de96798484288a0fffc4d54917d] source-hash-09e5de8278dd8f13adcf614db35c8a8a04ba8e47
git bisect good bebf9d31c8fe9de96798484288a0fffc4d54917d
# bad: [fac643700ecfabc737836bbed068776f34037d53] source-hash-40a61d93ade494fa98c23a9fd8776c8dadf8f30f
git bisect bad fac643700ecfabc737836bbed068776f34037d53
# bad: [d97d068402198fd528087c954ff8bf7fc2380a77] source-hash-3d1b1eea83703919c43620f9adef05e5b24c4bed
git bisect bad d97d068402198fd528087c954ff8bf7fc2380a77
# good: [3028c93bb1bec9aadbc210f29569c0b30b8cfd45] source-hash-3f0a8dc3c8204d6a500a5da64ad57996d593022f
git bisect good 3028c93bb1bec9aadbc210f29569c0b30b8cfd45
# good: [469dea83beaa20dde4b6d71e9520adbbed0925ca] source-hash-077a74cfc6dbea5ee275fd11b65b523cc525e2e4
git bisect good 469dea83beaa20dde4b6d71e9520adbbed0925ca
# good: [6dd9bc7210a274f38aef21edadb10cab192d3759] source-hash-1eb20c97e4d0f644efcf46aedac619a9765488c3
git bisect good 6dd9bc7210a274f38aef21edadb10cab192d3759
# good: [9e287f0939791627cc5cb0372043277178eb0155] source-hash-77b6c1602aaa0bd059077765e7fabb53d9e6ddeb
git bisect good 9e287f0939791627cc5cb0372043277178eb0155
# good: [929bc545099fc56ac8e76ecfb0a6ed9807e2542e] source-hash-7b56d303300fbf592473b28b654fd22fec110962
git bisect good 929bc545099fc56ac8e76ecfb0a6ed9807e2542e
# first bad commit: [d97d068402198fd528087c954ff8bf7fc2380a77] source-hash-3d1b1eea83703919c43620f9adef05e5b24c4bed
Comment 3 Michael Stahl 2014-05-27 19:01:02 UTC
it's caused by commit 04187aaf09969341a7ae9ae7ff5a13925381a96b
... but at first glance i'm not sure which of the 2 ways
to create the lists is the correct one.
Comment 4 reporter_of_bugs 2014-07-18 20:03:57 UTC
This bug is still present in 
Version: 4.3.0.3
Build ID: 08ebe52789a201dd7d38ef653ef7a48925e7f9f7

I've changed 'Version:'  to highest available in the dropdown box.
Comment 5 reporter_of_bugs 2014-07-26 01:39:11 UTC
changed to Version '4.3.0.3rc' now it is available in the list box.
Comment 6 Björn Michaelsen 2014-10-16 14:59:10 UTC
(This is an automated message.)

It seems that the commit that caused this regression was identified. (Or at least a commit is suspected as the offending one.)

Thus setting keyword "bisected".
Comment 7 xliiv 2014-10-24 15:29:51 UTC
What's next step since 'a commit is suspected as the offending one.'
Comment 8 Joel Madero 2014-10-24 15:48:41 UTC
The next step is to wait until someone has the time to dig into it more. Patience is part of the open source world :-D

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.