| Summary: | [BDW bisected]igt/kms_flip subcases cause "WARNING: CPU: 0 PID: 4846 at drivers/gpu/drm/i915/intel_display.c:3315 intel_crtc_wait_for_pending_flips+0xe6/0x13a [i915]()" | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | DRI | Reporter: | Guo Jinxian <jinxianx.guo> | ||||||||||
| Component: | DRM/Intel | Assignee: | Ville Syrjala <ville.syrjala> | ||||||||||
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||||||
| Severity: | blocker | ||||||||||||
| Priority: | highest | CC: | intel-gfx-bugs, james.ausmus, lei.a.liu, yi.sun | ||||||||||
| Version: | unspecified | ||||||||||||
| Hardware: | Other | ||||||||||||
| OS: | All | ||||||||||||
| Whiteboard: | |||||||||||||
| i915 platform: | i915 features: | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Guo Jinxian
2014-05-28 07:13:25 UTC
This commit should affect only the system suspend path and that isn't exercised according to the dmesg. So maybe this bug is not 100% reproducible and you need to try each bisect point before this commit multiple times. Ville might have a fix for this, so assigning it to him. Please test: http://patchwork.freedesktop.org/patch/26649/ (In reply to comment #3) > Please test: > http://patchwork.freedesktop.org/patch/26649/ The patch doesn't work. ------------------------------- [ 181.830550] WARNING: CPU: 1 PID: 4159 at drivers/gpu/drm/i915/intel_display.c:3315 intel_crtc_wait_for_pending_flips+0xe6/0x13a [i915]() [ 181.830564] Modules linked in: dm_mod snd_hda_codec_hdmi iTCO_wdt iTCO_vendor_support ppdev pcspkr i2c_i801 snd_hda_intel lpc_ich snd_hda_controller mfd_core snd_hda_codec snd_hwdep snd_pcm snd_timer snd soundcore battery parport_pc parport ac acpi_cpufreq i915 video button drm_kms_helper drm [ 181.830567] CPU: 1 PID: 4159 Comm: kms_flip Not tainted 3.15.0-rc3_prts_33d59c_20140529 #2 [ 181.830570] 0000000000000000 0000000000000009 ffffffff81723690 0000000000000000 [ 181.830572] ffffffff8103517a 0000000000000246 ffffffffa009fb10 0000000000000216 [ 181.830573] 0000000000000000 ffff880148d90000 ffff880144600000 ffff8800a6c27000 update priority because this impact tons of subcases and block QA's work. Created attachment 100438 [details] [review] Don't do vblank wait unconditionally Please test the attached patch on all affected testcases, thanks. Ignore this, wrong bug. Created attachment 101610 [details] [review] [PATCH] drm/i915: Wait for vblank after enabling the primary plane on BDW Looks like this turned out to be a bdw specific issue after all. The flip done interrupt seems to a bit broken on bdw. This patch should cure it. Created attachment 101638 [details] dmesg (In reply to comment #8) > Created attachment 101610 [details] [review] [review] > [PATCH] drm/i915: Wait for vblank after enabling the primary plane on BDW > > Looks like this turned out to be a bdw specific issue after all. The flip > done interrupt seems to a bit broken on bdw. This patch should cure it. The bug unable to reproduce with this patch. commit 33c3b0d19184cb11bfe8cf8e552918650f81f767 Author: Ville Syrjälä <ville.syrjala@linux.intel.com> Date: Tue Jun 24 13:59:28 2014 +0300 drm/i915: Wait for vblank after enabling the primary plane on BDW Verified on latest -nightly(9bfcb9dda09b60e9b44c21cf6277224c56450184). Closing verified+fixed. Fixed by commit 33c3b0d. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.