Bug 79407

Created attachment 100100 [details] [review]
Include windows.h, not Windows.h

How do you know the file is canonically named windows.h and not Windows.h ?

(In reply to comment #2)
> How do you know the file is canonically named windows.h and not Windows.h ?

There are other places in poppler's source code that all include 'windows.h' and have been there for a long time and have always worked for everyone.

The two additions of Windows.h are only included in a recent release.

(In reply to Albert Astals Cid from comment #2)
> How do you know the file is canonically named windows.h and not Windows.h ?

Even Microsoft's own documentation does not seem to be consistent w.r.t. this, e.g. [1] and [2]. But a grep for "windows.h" has 9 hits within Poppler whereas "Windows.h" has only these two.

[1] http://msdn.microsoft.com/en-us/library/bb384843.aspx

[2] http://msdn.microsoft.com/en-us/library/ms646257.aspx

Comment on attachment 100100 [details] [review]
Include windows.h, not Windows.h

Review of attachment 100100 [details] [review]:
-----------------------------------------------------------------

Look good to me. Windows filesystems are case insensitive so native builds will not be affected.

Pushed.