| Summary: | Add GIR support | ||
|---|---|---|---|
| Product: | Wocky | Reporter: | Guillaume Desmottes <guillaume.desmottes> |
| Component: | General | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | NEW --- | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | enhancement | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.collabora.com/git/user/cassidy/wocky/log/?h=gir | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Guillaume Desmottes
2014-06-03 14:37:43 UTC
+dist_gir_DATA = Wocky-1.gir
Why is this distributed in tarballs? (If there's no good reason, don't.)
+CLEANFILES += \
+ $(dist_gir_DATA) \
Please don't delete distributed files in "make clean".
> introspect all files
Can we use some variables rather than duplicating the file list?
Telepathy officially requires GNU make, so $(patsubst %,$(srcdir)/%,$(some_SOURCES)) is OK.
Looks good other than that. (In reply to comment #1) > +dist_gir_DATA = Wocky-1.gir > > Why is this distributed in tarballs? (If there's no good reason, don't.) > +CLEANFILES += \ > + $(dist_gir_DATA) \ > > Please don't delete distributed files in "make clean". I just cargo-culted introspection.am from tp-glib. Tartan needs the gir files to be installed but I guess we could not distribute it for now and tweak GI_TYPELIB_PATH manually. > > introspect all files > > Can we use some variables rather than duplicating the file list? > > Telepathy officially requires GNU make, so $(patsubst > %,$(srcdir)/%,$(some_SOURCES)) is OK. I considered using "Wocky_1_gir_FILES = $(libwocky_la_SOURCES)" which worked but that included -internal and -protected headers, which may be ok for now tbh. (In reply to comment #3) > I considered using "Wocky_1_gir_FILES = $(libwocky_la_SOURCES)" which worked > but that included -internal and -protected headers, which may be ok for now > tbh. You can use #ifndef __GI_SCANNER__ to hide those, if you need to. gtk-doc's /*<private_header>*/ rune might also work. (In reply to comment #4) > (In reply to comment #3) > > I considered using "Wocky_1_gir_FILES = $(libwocky_la_SOURCES)" which worked > > but that included -internal and -protected headers, which may be ok for now > > tbh. > > You can use #ifndef __GI_SCANNER__ to hide those, if you need to. > > gtk-doc's /*<private_header>*/ rune might also work. Ah good idea! I've done that. What's your opinion regarding distributing the gir file or not? |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.