Bug 79707

Summary:	Duplicate accelerator keys renders spell check dialog unusable with keyboard
Product:	LibreOffice	Reporter:	Darrell <darrella>
Component:	Writer	Assignee:	Caolán McNamara <caolanm>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	caolanm, philipz85, serval2412
Version:	4.1.6.2 release
Hardware:	Other
OS:	All
Whiteboard:	target:4.5.0 target:4.4.0.0.beta2
i915 platform:		i915 features:
Attachments:	how the dialog appears when you switch to grammar check (there is a blue highlight around the close button) spellcheck dialog in 4.0 spellcheck in word 2010 spellcheck in kingsoft writer

Description Darrell 2014-06-06 01:43:46 UTC

When performing a manual spell check (F7), using the keyboard is impossible because of duplicate accelerator keys.

Alt+G is a common accelerator for Ignore All in many apps, but the Check Grammar check box uses the same accelerator. Pressing Alt+G toggles between the Ignore All and Check Grammar check box, which creates the illusion of toggling between the Close button and Ignore All.

The Close and Correct buttons use the same Alt+C accelerators.

As Alt+G is common for Ignore All, the accelerator for Check Grammar should be changed.

Comment 1 Jay Philips 2014-06-06 19:31:44 UTC

Confirmed with LibO 4.1 and above. I'm assuming this happened when the dialog was redone.

Comment 2 Jay Philips 2014-06-06 19:32:30 UTC

Created attachment 100530 [details]
how the dialog appears when you switch to grammar check (there is a blue highlight around the close button)

Comment 3 Jay Philips 2014-06-06 19:35:17 UTC

Created attachment 100531 [details]
spellcheck dialog in 4.0

Comment 4 Julien Nabet 2014-06-06 22:20:34 UTC

On pc Debian x86-64 with master sources updated yesterday, I could reproduce this.
dialog is defined here:
cui/uiconfig/ui/spellingdialog.ui

Comment 5 Julien Nabet 2014-06-06 22:27:33 UTC

Suggestion:
- Ignore All -> "A"
- Add to Dictionary -> "D"
- Correct -> "O" (since "C" should be indeed for "Close")

Caolan: must we ping UX guys about this or does it only depend on devs?

Comment 6 Jay Philips 2014-06-07 00:20:59 UTC

Created attachment 100577 [details]
spellcheck in word 2010

Julien: i think we need to keep consistency with users have gotten used to already, but simply not have the blue highlight appear on the buttons when the grammar checkbox is gotten focus.

Comment 7 Jay Philips 2014-06-07 00:22:05 UTC

Created attachment 100578 [details]
spellcheck in kingsoft writer

Comment 8 Commit Notification 2014-11-26 16:18:25 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=da6ea10cd4a673661da016c6e8195f12876e7f73

Resolves: fdo#79707 duplicate acceserator keys in spell checking dialog

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Comment 9 Commit Notification 2014-11-26 16:19:37 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-4-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2493facca9c8067e6c8db286958d27bf3a13b71a&h=libreoffice-4-4

Resolves: fdo#79707 duplicate acceserator keys in spell checking dialog

It will be available in 4.4.0.0.beta2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.