Bug 79762

Summary: Include stdio.h from poppler-config.h
Product: poppler Reporter: Hib Eris <hib>
Component: generalAssignee: poppler-bugs <poppler-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Include stdio.h from poppler-config.h

Description Hib Eris 2014-06-07 08:14:57 UTC
In poppler-config.h there is a check for __MINGW_PRINTF_FORMAT,
which is set by stdio.h.

This fixes this warning when compling with the mingw-w64-compiler:

XRef.cc: In member function 'virtual void
XRef::XRefTableWriter::writeEntry(Goffset, int, XRefEntryType)':
XRef.cc:1460:94: warning: unknown conversion type character 'l' in format [-Wformat=]
    outStr->printf("%010lli %05i %c\r\n", (long long)offset, gen, (type==xrefEntryFree)?'f':'n');
^
XRef.cc:1460:94: warning: format '%i' expects argument of type 'int', but argument 3 has type 'Goffset {aka long long int}' [-Wformat=]
XRef.cc:1460:94: warning: too many arguments for format [-Wformat-extra-args]
Comment 1 Hib Eris 2014-06-07 08:15:01 UTC
Created attachment 100590 [details] [review]
Include stdio.h from poppler-config.h
Comment 2 Albert Astals Cid 2014-07-10 22:27:52 UTC
Pushed, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.