Bug 80118

Summary: [i965]Piglit spec_ARB_explicit_uniform_location_compiler_layout-01.frag fails
Product: Mesa Reporter: lu hua <huax.lu>
Component: Drivers/DRI/i965Assignee: Tapani Pälli <lemody>
Status: VERIFIED FIXED QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: normal    
Priority: medium CC: idr
Version: unspecified   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description lu hua 2014-06-17 06:11:24 UTC 
System Environment:
--------------------------
Platform: Haswell
Libdrm:		(master)libdrm-2.4.54-9-g8fc62ca8ac010659023bb63c4759eb683de4f9af
Mesa:		(master)d6fd8a97711eb065603a8d667ff5dbe68a246439
Xserver:	(master)xorg-server-1.15.99.902-121-g2f5cf9ff9a0f713b7e038636484c77f113a5f10a
Xf86_video_intel:(master)2.99.912-59-g38434b29f4a7b324704bbb1e772371be3c0e397b
Libva:		(staging)35e70cb9b9c77dfb99fb370e319ed501f0c31b17
Libva_intel_driver:(staging)9d49a6d693aa6c862467a4a879bc86d9cb98dbe5
Kernel:	(drm-intel-nightly)b438e8793c6d18b0998d75cdf8115a5898ed21d1

Bug detailed description:
-----------------------------
GL_ARB_explicit_uniform_location is enable on master branch, spec_ARB_explicit_uniform_location_compiler_layout-01.frag and spec_ARB_explicit_uniform_location_compiler_layout-01.vert fail on i965 platforms. they still skip on 10.2 branch

run bin/glslparsertest tests/spec/arb_explicit_uniform_location/compiler/layout-01.frag pass 1.10 GL_ARB_explicit_uniform_location
output:
Failed to compile fragment shader /GFX/Test/Piglit/piglit/tests/spec/arb_explicit_uniform_location/compiler/layout-01.frag: 0:8(10): error: GLSL 3.30 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.00 ES, and 3.00 ES

Shader source:
// [config]
// expect_result: pass
// glsl_version: 1.10
// require_extensions: GL_ARB_explicit_uniform_location
// [end config]
//

#version 330
#extension GL_ARB_explicit_uniform_location: require
vec4 color;
layout(location = 42) uniform float test1;
uniform float test2;
uniform float test3;

void main()
{
        color = vec4(1.0);
}

PIGLIT: {'result': 'fail' }

commit f3750a2c8667961c0595f5813b15be1476d13079
Author:     Tapani Pälli <tapani.palli@intel.com>
AuthorDate: Wed Mar 5 09:39:10 2014 +0200
Commit:     Tapani Pälli <tapani.palli@intel.com>
CommitDate: Mon Jun 16 06:49:59 2014 +0300

    Enable GL_ARB_explicit_uniform_location in the drivers.

    v2: enable also for i915 (Ian)

    Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
    Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Reproduce steps:
----------------------------
1. xinit
2. bin/glslparsertest tests/spec/arb_explicit_uniform_location/compiler/layout-01.frag pass 1.10 GL_ARB_explicit_uniform_location
Comment 1 Ian Romanick 2014-06-17 18:26:38 UTC 
It looks like the requirements section of the test is just wrong.
Comment 2 Tapani Pälli 2014-06-18 10:01:26 UTC 
will fix
Comment 3 Tapani Pälli 2014-06-18 10:19:31 UTC 
patch to bump glsl requirement to 3.30 sent to piglit mailing list
Comment 4 Tapani Pälli 2014-06-19 05:08:00 UTC 
patch pushed to master, now GLSL 3.30 required
Comment 5 lu hua 2014-06-20 02:29:44 UTC 
Verified.Fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.