Bug 80292

Summary: HTML Document: Insert Table always insert a one-column table
Product: LibreOffice Reporter: Kevin Suo <suokunlong>
Component: LibreofficeAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED WORKSFORME QA Contact:
Severity: critical    
Priority: highest CC: caolanm, jmadero.dev, pierre-yves.samyn, serval2412, suokunlong
Version: 4.2.5.2 releaseKeywords: have-backtrace
Hardware: x86 (IA32)   
OS: Linux (All)   
See Also: https://bugs.freedesktop.org/show_bug.cgi?id=80345
Whiteboard:
i915 platform: i915 features:
Attachments: bt console from master sources
an HTML document with 8*8 table created with LibreOffice

Description Kevin Suo 2014-06-20 14:49:43 UTC
Steps:
1. Start LibreOffice;
2. File - New - HTML Document;
3. Table - Insert - Table:  8 rows 8 columns

Current Result:
It always insert a table with only one column.

Reproduce with: 
4.2.5.2, 4.3.0.1
Ubuntu 14.04 x86

Functionality broken -> Blocker
Comment 1 Kevin Suo 2014-06-20 14:53:08 UTC
Well...I assume few people uses libreoffice to design HTML document, so I lower it to CRITICAL.
Comment 2 pierre-yves samyn 2014-06-20 15:08:46 UTC
Hi

I'm not sure: have you show displayed the non printing characters?
You will see the columns (not table columns).

Tested on windows 7/64 & 
Version: 4.2.5.1
Build ID: 881bb88abfe2992c6cede97c23e64a9885de87de
Version: 4.3.0.1
Build ID: 67f5430184326974072b65403ef1d9d934fc4481

Regards
Pierre-Yves
Comment 3 Julien Nabet 2014-06-20 23:01:33 UTC
Created attachment 101463 [details]
bt console from master sources

On pc Debian x86-64 with master sources updated today (+ enable-dbg), I had a crash.
I don't know if it's related but thought it might be interested because we can see console logs like these:
warn:vcl.layout:9616:1:vcl/source/window/builder.cxx:1598: probably need to implement swlo-TableNameEdit or add a makeswlo-TableNameEdit function
warn:vcl:9616:1:vcl/source/window/builder.cxx:212: missing either source label3 or target nameedit member of Mnemonic Widget Mapping
warn:vcl.layout:9616:1:include/vcl/builder.hxx:268: widget "nameedit" not found in .ui
warn:vcl.layout:9616:1:include/vcl/builder.hxx:270: .ui widget "nameedit" needs to correspond to vcl type 4Edit
Comment 4 Julien Nabet 2014-06-20 23:03:34 UTC
Caolán: one for you? (I attached bt which shows a vcl part)

(If needed, I can create a separate bugtracker)
Comment 5 Kevin Suo 2014-06-21 00:35:32 UTC
(In reply to comment #2)
> I'm not sure: have you show displayed the non printing characters?
> You will see the columns (not table columns).

Hi pierre-yves, thanks for you info, I checked again, and I see that:
When I insert a 8*8 table, there are really 8 columns, the only porblem is that the columns have no right and left borders applied, so they look like one-column.

When I save the HTML document with 8*8 table and view HTML source, I see the following for each <td> tag:

<td width="13%" ... border-right: none;...>

So maybe the "border-right: none" caused the problem.
When you insert a table, it should never by default to set top-bottom borders to not-none but left-right borders to none.

So maybe I should close this one as WORKSFORME, and open another report on table border issue?
Comment 6 Kevin Suo 2014-06-21 00:40:49 UTC
Created attachment 101464 [details]
an HTML document with 8*8 table created with LibreOffice

This HTML document was created with libreoffice 4.3.0.1. (File - New - HTML Document)
The table was inserted by "Table - Insert - Table".
Comment 7 pierre-yves samyn 2014-06-21 05:14:51 UTC
Hi

(In reply to comment #5)
> So maybe I should close this one as WORKSFORME, and open another report on
> table border issue?

Perhaps? Sorry, I do not know enough html to provide proper notice

Regards
Pierre-Yves
Comment 8 Kevin Suo 2014-06-22 03:41:42 UTC
I closed this bug and filed a new bug:
Bug 80345 - HTML Document: Insert Table always insert a table with no right and left border

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.