| Summary: | xorg-server-1.15.99.903 - Xvfb Segmentation fault at address 0x18 | ||
|---|---|---|---|
| Product: | xorg | Reporter: | Bertrand Jacquin <bertrand> |
| Component: | Server/DDX/Xvfb | Assignee: | Xorg Project Team <xorg-team> |
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> |
| Severity: | normal | ||
| Priority: | medium | CC: | bertrand, bugs, keithp, thierry.vignaud |
| Version: | unspecified | ||
| Hardware: | x86 (IA32) | ||
| OS: | Linux (All) | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=514032 | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Bertrand Jacquin
2014-06-20 22:13:30 UTC
444a1f7a8802999e27ecf5f6eb598df2206f7277 is the first bad commit commit 444a1f7a8802999e27ecf5f6eb598df2206f7277 Author: Brendan King <brendan.king@imgtec.com> Date: Thu Apr 24 11:37:45 2014 +0100 fb: fix screen pixmap leak on server reset Call FreePixmap() instead of free() to destroy the screen pixmap in fbCloseScreen(). Signed-off-by: Frank Binns <frank.binns@imgtec.com> Reviewed-by: Keith Packard <keithp@keithp.com> Signed-off-by: Keith Packard <keithp@keithp.com> (In reply to comment #1) > 444a1f7a8802999e27ecf5f6eb598df2206f7277 is the first bad commit > commit 444a1f7a8802999e27ecf5f6eb598df2206f7277 > Author: Brendan King <brendan.king@imgtec.com> > Date: Thu Apr 24 11:37:45 2014 +0100 > > fb: fix screen pixmap leak on server reset > > Call FreePixmap() instead of free() to destroy the screen pixmap in > fbCloseScreen(). > > Signed-off-by: Frank Binns <frank.binns@imgtec.com> > Reviewed-by: Keith Packard <keithp@keithp.com> > Signed-off-by: Keith Packard <keithp@keithp.com> Perfect, thank you. How about we have fb just check to see if devPrivate is NULL before calling FreePixmap then? That's easy to do. commit 10d2805dbc6b96a159b8c5acedcd53f34df362bf Author: Keith Packard <keithp@keithp.com> Date: Thu Jun 26 14:12:24 2014 -0700 fb: Don't free NULL pixmap in fbCloseScreen. Bug #80313 We fixed fbCloseScreen to use the FreePixmap function so that the private counts would be updated correctly during CloseScreen. Xvfb calls FreePixmap and sets devPrivate to NULL before fbCloseScreen is called; not checking devPrivate before calling would result in a NULL pointer dereference. Signed-off-by: Keith Packard <keithp@keithp.com> Reviewed-by: Julien Cristau <jcristau@debian.org> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.