Bug 81410

Summary: [BDW Bisected]igt/kms_universal_plane/universal-plane-pipe-A-functional fails
Product: DRI Reporter: Guo Jinxian <jinxianx.guo>
Component: DRM/IntelAssignee: Ville Syrjala <ville.syrjala>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: highest CC: intel-gfx-bugs, ming.yao
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
dmesg
none
dmesg none

Description Guo Jinxian 2014-07-16 06:04:16 UTC
Created attachment 102895 [details]
dmesg

==System Environment==
--------------------------
Regression: Yes
The result was skipped on -next-queued(91565c85b66db820f01894a971d39aaef60c4325)

Non-working platforms: BDW

==kernel==
--------------------------
origin/drm-intel-nightly: 77820625217fa547586f00be7cae56e5c5e255bf(fails)
    drm-intel-nightly: 2014y-07m-15d-17h-27m-04s integration manifest
origin/drm-intel-next-queued: c8c683d05f05d35c2f0159ae5ee266383819376a(fails)
    ddrm/i915: Make the WRPLL names const
origin/drm-intel-fixes: c6930992948adf0f8fc1f6ff1da51c5002a2cf95(skips)
    Revert "drm/i915: reverse dp link param selection, prefer fast over wide again"

==Bug detailed description==
igt/kms_universal_plane/universal-plane-pipe-A-functional fails

Output:
[root@x-bdw01 tests]# ./kms_universal_plane --run-subtest universal-plane-pipe-A-functional
IGT-Version: 1.7-g3f50598 (x86_64) (Linux: 3.16.0-rc5_drm-intel-nightly_778206_20140716+ x86_64)
Testing connector eDP-1 using pipe A
Test assertion failure function functional_test_pipe, file kms_universal_plane.c:269:
Failed assertion: igt_crc_equal(&test.crc_2, &test.crc_4)
Subtest universal-plane-pipe-A-functional: FAIL


==Reproduce steps==
---------------------------- 
1. ./kms_universal_plane --run-subtest universal-plane-pipe-A-functional
Comment 1 yaoming 2014-08-04 06:55:44 UTC
Test passed on latest -next-queued and latest -nightly on BDW.

[root@x-bdw01 tests]# ./kms_universal_plane --run-subtest universal-plane-pipe-A-functional
IGT-Version: 1.7-gde1e877 (x86_64) (Linux: 3.16.0-rc4_drm-intel-next-queued_17c58f_20140804+ x86_64)
Testing connector eDP-1 using pipe A
Subtest universal-plane-pipe-A-functional: SUCCESS

[root@x-bdw01 tests]# ./kms_universal_plane --run-subtest universal-plane-pipe-A-functional
IGT-Version: 1.7-g2fae99b (x86_64) (Linux: 3.16.0-rc6_drm-intel-nightly_ddbc28_20140804+ x86_64)
Testing connector eDP-1 using pipe A
Subtest universal-plane-pipe-A-functional: SUCCESS
Comment 2 yaoming 2014-08-05 03:21:05 UTC
This issue has been fixed on the latest drm-intel-nightly branch.
Comment 3 Guo Jinxian 2014-08-11 02:52:04 UTC
This issue still able to reproduce on latest -fixes(be71eabebaf9f142612d34d42292b454e984dcb5). Maybe the fixed patch doesn't marge into -fixes branch. I will check it later.

[root@x-ivb6 tests]# ./kms_universal_plane --run-subtest universal-plane-pipe-A-functional
IGT-Version: 1.7-ga17f060 (x86_64) (Linux: 3.16.0_drm-intel-fixes_be71ea_20140810+ x86_64)
Testing connector HDMI-A-3 using pipe A
Test assertion failure function functional_test_pipe, file kms_universal_plane.c:275:
Failed assertion: igt_crc_equal(&test.crc_2, &test.crc_6)
Subtest universal-plane-pipe-A-functional: FAIL
Comment 4 Guo Jinxian 2014-09-04 07:40:56 UTC
Created attachment 105722 [details]
dmesg

This bug still able to reproduce on BDW on latest -nightly(2b1159961e4bc38a9090f8ec0ab6f16701dbdf81)

root@x-bdw05:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./kms_universal_plane --run-subtest universal-plane-pipe-A-functional
IGT-Version: 1.7-gf473a55 (x86_64) (Linux: 3.17.0-rc2_drm-intel-nightly_4144c9_20140904+ x86_64)
Testing connector eDP-1 using pipe A
Test assertion failure function functional_test_pipe, file kms_universal_plane.c:294:
Failed assertion: igt_crc_equal(&test.crc_5, &test.crc_9)
Subtest universal-plane-pipe-A-functional: FAIL
Comment 5 Guo Jinxian 2014-09-09 02:23:17 UTC
ab60c84d87edffe6555fc9f1703e8f9074d06416 is the first bad commit.

commit ab60c84d87edffe6555fc9f1703e8f9074d06416
Author:     Ville Syrjälä <ville.syrjala@linux.intel.com>
AuthorDate: Mon Sep 1 18:08:25 2014 +0300
Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Tue Sep 2 17:25:47 2014 +0200

    drm/i915: Don't call intel_plane_restore() when the prop value didn't change
    
    No point in calling intel_plane_restore() in .set_property() if the
    value didn't change.
    
    More importantly this papers over a bug where the current primary plane
    code forgets to update the user coordinates we store under intel_plane
    unless the primary plane .update_plane() hook is actually called. This
    means we have 0 in the coordinates straight after boot and any call
    to intel_restore_plane() (such as from restore_fbdev_mode()) will
    actually turn off the primary plane. This mess needs to be fixed properly
    but that's a bigger task and the first step there is killing off
    intel_pipe_set_base() and just calling the primary plane
    .update_plane() hook. For the immediate problem of black screen after
    boot this small patch is enough to hide it.
    
    The problem originates from these two commits:
     commit 3a5f87c286515c54ff5c52c3e64d0c522b7570c0
     Author: Thomas Wood <thomas.wood@intel.com>
     Date:   Wed Aug 20 14:45:00 2014 +0100
    
        drm: fix plane rotation when restoring fbdev configuration
    
     commit d91a2cb8e5104233c02bbde539bd4ee455ec12ac
     Author: Sonika Jindal <sonika.jindal@intel.com>
     Date:   Fri Aug 22 14:06:04 2014 +0530
    
        drm/i915: Add 180 degree primary plane rotation support
    
    Cc: Thomas Wood <thomas.wood@intel.com>
    Cc: Sonika Jindal <sonika.jindal@intel.com>
    Tested-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
    Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
    Tested-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Comment 6 Jani Nikula 2014-09-09 07:31:02 UTC
See also https://bugs.freedesktop.org/show_bug.cgi?id=83640
Comment 7 Rodrigo Vivi 2014-09-26 19:36:43 UTC
As on #83640 I don't believe this bisect result is correct.
Could you please do the same as I asked on 83640?
Comment 8 Guo Jinxian 2014-09-28 05:11:25 UTC
The failure unable to reproduce on latest -nightly(7101d84020f63f1da7e0c5d021cdd6be4d515de5)

root@x-bdw05:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./kms_universal_plane --run-subtest universal-plane-pipe-A-functional
IGT-Version: 1.8-g3205a91 (x86_64) (Linux: 3.17.0-rc6_drm-intel-nightly_7101d8_20140928+ x86_64)
Testing connector eDP-1 using pipe A
Subtest universal-plane-pipe-A-functional: SUCCESS (2.182s)
root@x-bdw05:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# echo $?
0
Comment 9 Jari Tahvanainen 2017-02-10 08:50:28 UTC
Closing (>2 years) old Verified+Fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.