| Summary: | Japanese text not rendered from a pdf | ||
|---|---|---|---|
| Product: | poppler | Reporter: | Jehan <jehan> |
| Component: | general | Assignee: | poppler-bugs <poppler-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Katakana pdf
poppler-data: add a pkg-config file. poppler: use poppler-data pkg-config poppler: use poppler-data pkg-config for both cmake and autotools builds. poppler-data: Adding a pkg-config file Template poppler-data.pc.in forgotten. |
||
|
Description
Jehan
2014-07-25 14:40:22 UTC
Do people in windows have poppler-data installed? Created attachment 103512 [details] [review] poppler-data: add a pkg-config file. Oh! Well indeed when I install this in my dev build, it works. I guess our official release does not have it either, then. Could I propose an improvement to poppler-data package? I submit a pkg-config file. This would allow third-party to decide whether they want to have a strong dependency to poppler-data (or at least a warning maybe for the packager if poppler-data is missing). I know pkg-config is rather known to be used for libraries, but it is also actually very commonly used for data packages as well (check your /usr/share/pkgconfig/, you will likely see a lot of .pc files for data packages there). If you were to add this pkg-config, we would likely add at least a check of poppler-data with a warning on GIMP configure script. As a side feature, it will allow the poppler package to detect the right path for the datadir. Right now, poppler determines the data root either if the packager explicitely gives the --datarootdir option, or by assuming by default it will be on the same prefix as poppler itself. Using pkg-config simplifies and gives flexibility. Attached patch: 0001-Adding-a-pkg-config-file-for-poppler-data.patch Created attachment 103514 [details] [review] poppler: use poppler-data pkg-config And a second patch, for the poppler repo this time, which would use the new pkg-config of poppler-data if it exists to determine the datadir path. Sincerely, i don't see the need, the method we have now works. Changing it will probably break some other people's stuff. Well, you choose. But pkg-config won't ever break any existing script. pkg-config has ever been just a *plus*, not a replacement. If someone don't care and don't want to use pkg-config, this won't break anything existing currently. On the other hand, if someone would like to check for the package existence, pkg-config is the cleaner and safer existing way. A lot of data packages use pkg-config (checking my /usr/share/pkgconfig, I see: iso codes, GNOME themes, udev, X Keyboard configuration data, Freedesktop common MIME db...). That's just the best current way currently to link a program to a set of independent data which could be anywhere in the system. Also there is another advantage: it will allow also to manage versionning. If you improve your encoding packages, add new ones, or fix existing, right now there is no way for a third party to ensure to have the right versions. With pkg-config, you could add dependencies based on versions. In any case, I repeat: that won't break any existing stuff. That just adds a .pc file in the datadir. If third party don't care, they just don't use it. The existing script will still work. I know that in GIMP, I will care so that the next Windows (or other) builds, the packager would not forget the package. Well, at least it seems to me you're ignoring the cmake buildsystem side, that needs fixing before any discussion if this needs to go in or not. Created attachment 103586 [details] [review] poppler: use poppler-data pkg-config for both cmake and autotools builds. You are right! Patch updated, which takes both autotools and cmake into account. Hi again, Did you consider my patches? :-) Thanks! Can you fix the poppler-data patch so that make dist actually creates poppler-data.pc if it's not there? And adds it to the tarball. Created attachment 104513 [details] [review] poppler-data: Adding a pkg-config file Hi, Sure! Actually we want to include poppler-data.pc.in since $pkgdatadir may change depending on make install invocation. Well I included both in the dist. Also since you don't have a configure step, I realized we want to force-generate poppler-data.pc at each `make install` for the same reason. So I made a small update to this script to do this. Attached. Thanks! Pushed. Thanks. Hi, Thanks. But it seems that you removed the poppler-data.pc.in from my patch when you amended it. :-) So that's broken right now. Created attachment 104519 [details] [review] Template poppler-data.pc.in forgotten. Hey just to be sure this is not forgotten, I reopen. I also reattach a patch for just this forgotten file (though you could also get it from my previous patch. That's the same). Thanks. I forgot to push the file |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.