Bug 81822

Summary: Missing NULL check on xim
Product: xorg Reporter: Drew Moseley <drew>
Component: Lib/XlibAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: git   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Patch to add the missing checks for NULL. none

Description Drew Moseley 2014-07-27 22:42:10 UTC
Created attachment 103568 [details]
Patch to add the missing checks for NULL.

ICWrap.c dereferences the xim parameter passed in from client code without a NULL check.  I have seen mplayer trigger this resulting in a segfault.  In this case mplayer had called XOpenIM and NULL was returned which was later passed into XCreateIC.
Comment 1 Ross Burton 2015-05-18 13:54:07 UTC
Updated for master and resent to xorg-devel today.
Comment 2 Alan Coopersmith 2018-03-24 07:05:32 UTC
Patch was pushed shortly after last update - forgot to close the bug report:
https://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=c827edcd1c4a7f920aa25208083b5b58d60d2b44

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.