| Summary: | Using "Floating" option set to "On" causes server to SEGV | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Simon Munton <simon.j.munton> | ||||||
| Component: | Server/Input/Core | Assignee: | Xorg Project Team <xorg-team> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||||
| Severity: | normal | ||||||||
| Priority: | medium | CC: | kyle, nbowler, peter.hutterer | ||||||
| Version: | unspecified | Keywords: | patch | ||||||
| Hardware: | x86-64 (AMD64) | ||||||||
| OS: | Linux (All) | ||||||||
| Whiteboard: | |||||||||
| i915 platform: | i915 features: | ||||||||
| Attachments: |
|
||||||||
Created attachment 103898 [details] [review] Patch to prevent NULL pointer being passed to XkbPushLockedStateToSlaves Found that when "Floating" was set to "on", XkbPushLockedStateToSlaves was called with a NULL pointer passed as first argument. Patch checks for NULL pointer and if it is NULL then it does not call XkbPushLockedStateToSlaves Confirming that Peter's patch fixes the problem This regression is still present in server 1.16.1... any reason the fix was not included? It is impossible to start the server at all with this bug. closing as fixed, patch is on master. sent a request for 1.16.2, so that should be done soon too. commit 1e30fc1b99bda040038e4fd56d1b27c686b44c75 Author: Peter Hutterer <peter.hutterer@who-t.net> Date: Mon Aug 4 10:47:03 2014 +1000 xkb: ignore floating slave devices when updating from master (#81885) commit on the 1.16 branch: 0e62f275aa02c5694fd714f3bbd5271836142755 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 103654 [details] Xorg.log I was experimenting with adding a bluetooth keyboard/mouse (a Rii Mini) and as part of trying to get it set up, I had the following in a file in /etc/X11/xorg.conf.d Section "InputClass" Identifier "Keyboard Defaults 1" MatchProduct "Macro Keyboard" MatchIsKeyboard "yes" Option "xkb_model" "pc101" Option "XkbLayout" "us" Option "Floating" "On" Driver "evdev" EndSection With the Option "Floating" line present, X would crash either at startup if the device was already on, or later if the device was turned on after X had started. Xorg.log attached.