Bug 81986

Summary:

[BDW Bisected] etqw-demo/lightsmark/warsow01/unigine-demos/Synmark2_v6/GLBenchmarkv2.5.1/v2.7.0 performance reduced 10%~50%

Product:

DRI

Reporter:

zhoujian <jianx.zhou>

Component:

DRM/Intel

Assignee:

Jesse Barnes <jbarnes>

Status:

CLOSED FIXED

QA Contact:

Intel GFX Bugs mailing list <intel-gfx-bugs>

Severity:

major

Priority:

high

CC:

daniel, eero.t.tamminen, intel-gfx-bugs, mika.kuoppala, wendy.wang

Version:

unspecified

Hardware:

All

OS:

Linux (All)

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
drm/i915: move string assignments out of fast path	none
drm/i915: make detecting of unclaimed registers optional	none
drm/i915: Use raw access from inside interrupt handlers	none

Description zhoujian 2014-08-01 02:21:45 UTC

Environment:
----------------------------------------------
Platform: BDW
Libdrm: (master)libdrm-2.4.56
Mesa: (master)66decc7efa08ae9c94e4bd11038cfe8b3132d554
Xserver: (master)xorg-server-1.15.99.902-121-g2f5cf9ff9a0f713b7e038636484c77f113a5f10a
Xf86_video_intel: (master)2.99.914-8-ga88795c64123e4084044451d8861838ea904abd9
Cairo: (master)f337342c88092a251dc00476c4a9880d1cb90822
Libva: (master)3fddb7f937df4e0e15391bd65ae3c7552ea5b3d7
Libva_intel_driver: (master)82d2ed8d7da3619c0ea467c06604f5626fc0b901
Kernel:	(drm-intel-nightly) git-eb2af9

Bug detailed description:
---------------------------------------------------
etqw-demo/lightsmark/warsow01/unigine demos/GLBenchmark_2.5.1/GLBenchmark_v2.7.0/3DMMES2_taiji/ hoverjet/Synmark2_v6_(OglFillTexMulti/OglPSBump2/OglPSBump8/OglPSPhong/OglPSPom/OglShMapPcf/ OglShMapVsm/OglTexFilterTri/OglTexMem128/OglTexMem512/OglDeferred) performance reduced 10%~50%.
This problem doesn’t exist on IVB/BYT-M/HSW, The problem exists both on gnome-session and Raw X.
BTW, after revert bad commit, it can works well.
It’s Kernel(drm-intel-next-queued) regression, bisecting show that the first bad commit is: 66bc2cab191816d931f4d660d2f162130dd202b2
Author:     Paulo Zanoni <paulo.r.zanoni@intel.com>
AuthorDate: Wed Jul 16 17:49:30 2014 -0300
Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Wed Jul 23 07:05:37 2014 +0200

    drm/i915: BDW can also detect unclaimed registers


Reproduce steps:
---------------------------------------------
1.	xinit&
2.	vblank_mode=0 ./backend silent 1920x1080

Comment 1 zhoujian 2014-08-01 02:23:16 UTC

This issue only happened on BDW.

Comment 2 zhoujian 2014-08-04 03:18:42 UTC

This issue also exists on drm-intel-nightly branch,it's works well on drm-intel-fixes branch.

Comment 3 Mika Kuoppala 2014-08-04 09:03:33 UTC

Created attachment 103983 [details] [review]
drm/i915: move string assignments out of fast path

Comment 4 Mika Kuoppala 2014-08-04 09:04:44 UTC

Created attachment 103984 [details] [review]
drm/i915: make detecting of unclaimed registers optional

Comment 5 Mika Kuoppala 2014-08-04 09:05:48 UTC

Could you please test the effect performance impact of attached patches separately?

Comment 6 Mika Kuoppala 2014-08-04 09:08:55 UTC

(In reply to comment #5)
> Could you please test the effect performance impact of attached patches
> separately?

Actually best just to test first only:
drm/i915: move string assignments out of fast path

Then both apply both.

Comment 7 Chris Wilson 2014-08-04 09:35:12 UTC

You could also use one of my earlier patches to use raw register access from inside the irq handlers.

Comment 8 Mika Kuoppala 2014-08-04 14:48:49 UTC

Created attachment 103998 [details] [review]
drm/i915: Use raw access from inside interrupt handlers

Another patch to try, based on what Chris suggested

Comment 9 zhoujian 2014-08-05 05:41:00 UTC

Have tried the patch:"drm/i915: make detecting of unclaimed registers optional",it's can fixed this issue,other patch doesn't fixed it.

Comment 10 zhoujian 2014-08-12 02:36:43 UTC

Verified it,fixed commit as below:
 Libdrm:(master)libdrm-2.4.56-4-g07fead4462b2d537d0c3cae69a09272fc426c59
 Mesa:(master)9276ef6f41626307c3da2ed94a77c0d51b6d8efd
 Xserver:(master)xorg-server-1.15.99.902-121-g2f5cf9ff9a0f713b7e038636
 Xf86_video_intel:(master)2.99.914-42-g8e1961e7fc163f3103b2260cca965aef
 Cairo:master)c7ff9bb32e20679d6da4e8a2856be716e5bd9e12
 Libva:(master)3fddb7f937df4e0e15391bd65ae3c7552ea5b3d7
 Libva_intel_driver:(master)82d2ed8d7da3619c0ea467c06604f5626fc0b901
 kernel:(drm-intel-nightly 2014_08_11)git-ee55e7

Comment 11 Elizabeth 2017-10-06 14:36:49 UTC

Closing old verified.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.