Bug 8208

Summary:	XCB error cookie gives too little diagnostic information
Product:	XCB	Reporter:	Bart Massey <x>
Component:	Library	Assignee:	Jamey Sharp <jamey>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	highest
Version:	0.9
Hardware:	x86 (IA32)
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	6797

Description Bart Massey 2006-09-09 16:00:18 UTC

When XCB request generation fails, a request cookie with a sequence number of
zero is returned.  Unfortunately, applications may need to know more than that
there was just a failure.  In particular, XCB requests may need to use an
extension implicitly to complete (e.g. BIGREQUESTS) and may find that the server
doesn't support that extension.

Is an API change needed here?  We don't currently know.

Comment 1 Bart Massey 2006-09-09 22:53:46 UTC

Better summary title added.

Comment 2 Jamey Sharp 2006-09-15 02:31:26 UTC

I've posted a series of patches to fix this on the mailing list. After a
suitable review period I'll push them and close this bug.

Comment 3 Jamey Sharp 2006-09-15 11:08:53 UTC

Ian Osgood noticed a bug in my patch set: it calls get_event from
XCBPollForEvent without holding the lock.

Ian also suggests renaming XCBConnectionHasError to XCBDisconnected.

Comment 4 Jamey Sharp 2006-09-22 01:29:36 UTC

I've pushed a revised set of patches that addresses the bug Ian noticed, and
seems correct to me.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.