Bug 82280

Summary: [PNV]igt/kms_flip_tiling/flip-changes-tiling tests timeout
Product: DRI Reporter: Guo Jinxian <jinxianx.guo>
Component: DRM/IntelAssignee: Jesse Barnes <jbarnes>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: intel-gfx-bugs
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
dmesg none

Description Guo Jinxian 2014-08-07 05:52:24 UTC
Created attachment 104199 [details]
dmesg

==System Environment==
--------------------------
Regression: No. 
The case always failed, which was tracked by bug 78280

Non-working platforms: PNV

==kernel==
--------------------------
origin/drm-intel-nightly: 5a299a5a794999ddcc44578c0cfd58da83bac62b(timeout)
    drm-intel-nightly: 2014y-08m-06d-22h-47m-43s integration manifest
origin/drm-intel-next-queued: 290a60e8b9bc9174abef251ca5498ba725c61859(fails)
    drm/i915: Round-up clock and limit drain latency
origin/drm-intel-fixes: 96d56d71a3bcd0a0015034a8f3decc46cb9ec855(fails)
    drm/i915: Fix crash when failing to parse MIPI VBT

==Bug detailed description==
igt/kms_flip_tiling/flip-changes-tiling tests timeout

Output:
[root@x-pnv2 tests]# ./kms_flip_tiling --run-subtest flip-changes-tiling
IGT-Version: 1.7-gac31f19 (i686) (Linux: 3.16.0_drm-intel-next-queued_290a60_20140807+ i686)
Subtest flip-changes-tiling: TIMEOUT

==Reproduce steps==
---------------------------- 
1. ./kms_flip_tiling --run-subtest flip-changes-tiling
Comment 1 Chris Wilson 2014-08-25 12:26:17 UTC
Tries to use pipe 0 with LVDS, fails to setup the output and blocks forever waiting for a vblank interrupt.
Comment 2 Chris Wilson 2014-08-27 09:55:59 UTC
Retested without the extra vblank patches, and it works with just fixing kms_flip_tiling to use the right pipe.
Comment 3 Guo Jinxian 2014-08-28 07:28:13 UTC
Test still timeout on latest -nightly(e91331cf71c509af3dfae75cd9bca3db13d7da95) on PNV

[root@x-pnv2 tests]# ./kms_flip_tiling --run-subtest flip-changes-tiling
IGT-Version: 1.7-g50166d2 (i686) (Linux: 3.17.0-rc2_drm-intel-nightly_e91331_20140828+ i686)
Subtest flip-changes-tiling: TIMEOUT
Comment 4 Chris Wilson 2014-09-07 15:19:42 UTC
I think it should be as simple as:

diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
index 1f2caac..9c2f7fe 100644
--- a/tests/kms_flip_tiling.c
+++ b/tests/kms_flip_tiling.c
@@ -67,9 +67,9 @@ test_flip_changes_tiling(data_t *data, igt_output_t *output)
        igt_crc_t reference_crc, crc;
        int fb_id, pipe, ret, width;
 
-       pipe = 0;
+       pipe = output->config.pipe;
        pipe_crc = igt_pipe_crc_new(pipe, INTEL_PIPE_CRC_SOURCE_AUTO);
-       igt_output_set_pipe(output, 0);
+       igt_output_set_pipe(output, pipe);
 
but now the pipe crc fails to open.
Comment 5 Chris Wilson 2014-09-08 11:56:55 UTC
commit be6bb4ce4a413df5ec385523313a4e2a3894d4c8
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Sun Sep 7 15:52:10 2014 +0100

    igt/kms_flip_tiling: Use the associated pipe for the output
    
    This stops us from using an illegal pipe, such as pipe 0 for LVDS on
    PNV.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82280
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Comment 6 Guo Jinxian 2014-09-10 09:06:46 UTC
Verified 
I will report a new bug for this failure.

[root@x-pnv2 tests]# ./kms_flip_tiling --run-subtest flip-changes-tiling
IGT-Version: 1.8-gd9d3f4b (i686) (Linux: 3.17.0-rc4_drm-intel-nightly_99f444_20140910+ i686)
Test assertion failure function igt_primary_plane_commit_legacy, file igt_kms.c:1419:
Failed assertion: ret == 0
Last errno: 13, Permission denied
Subtest flip-changes-tiling: FAIL (0.202s)
Comment 7 Jari Tahvanainen 2017-05-19 08:59:33 UTC
Closing verified+fixed

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.