Summary: | Ctrl-F should show or focus the find box, NOT toggle it | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | freedesktop |
Component: | ux-advise | Assignee: | Samuel Mehrbrodt <s.mehrbrodt> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | low | CC: | cno, jorendc, libreoffice-ux-advise, pedlino, s.mehrbrodt, vstuart.foote |
Version: | 4.2.6.2 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=59101 | ||
Whiteboard: | target:4.4.0 | ||
i915 platform: | i915 features: |
Description
freedesktop
2014-08-12 10:06:57 UTC
Hi, thanks for your report. So you simply suggest: "Don't let Ctrl+F close the find bar when it has the focus" No problem for me, I just wonder why one should hit Ctr-F when the focus is in the find-box already ;) Cheers Cor Yep, pretty much :) Much quicker to find when you don't have to check whether there's a cursor in the find box first and can just hit ctrl-F - and for example when you're context-switching (e.g. composing an email and searching a document for reference) it's pretty easy to be in a position where you don't know straight away whether the find box is focused. Well, as can be seen in bug 59101 one reason for the the adjustment to <Ctrl>+F --Find-- was to make it consistent with behavior of <Ctrl>+H --Find/Replace-- dialog. Personally I don't care if it is a toggle, e.g. a second <Ctrl>+F or <Crtl>+H, or just an <Esc> command to close the dialog. As long as UI is consistent in handling these search tools. But, adding Pedro & Joren for their comment. I like Firefox' behavior: When the focus is in the search field and there is some text in it, and you hit Ctrl-F again, the text get selected so you can start a new search. Closing the search bar with Ctrl-F doesn't make sense to me - why would you do that; you can use ESC. As I said we can't do good for everyone, and as I explained in the other bug report (bug 59101) the behavior is like this: 1) if your focus is on the document, findbar closed -> ctrl+F opens findbar + focus on findbar 2) if your focus is on the document, findbar opened -> focus to findbar 3) if your focus is on the findbar, press ESC or ctrl+F will close the findbar I do like this behavior (and it looks like others do share that too). It makes more sense to me to just close it if you are already focused on the findbar (in other cases it'll grab focus/open). But if I'm alone in that opinion feel free to revert my patch. I'll mark it as '0' so someone else has to push it. Kind regards, Joren (In reply to comment #4) > I like Firefox' behavior: > When the focus is in the search field and there is some text in it, and you > hit Ctrl-F again, the text get selected so you can start a new search. Is nice indeed. > Closing the search bar with Ctrl-F doesn't make sense to me - why would you > do that; you can use ESC. Ctrl-F is closer then ESC - though I can find the latter without looking of course (In reply to comment #5) > But if I'm alone in that opinion feel free to revert my patch. I wouldn't spoil my sleep for this. IMO it's really a minor issue (if any) in the over all great functioning of the find bar. For those who disagree with this bug, please read my rationale and respond to it fully, addressing each of the issues I have raised with current behaviour. V Stuart Foote - for consistency Ctrl-H behaviour could be adjusted as suggested (when the replace dialogue is open, Ctrl-H does nothing and Esc closes). I did a quick check on my installed editors (Word, Excel and notepad++ on Windows and gedit and Geany on Linux) and at least they all behave like this. Also, on Linux at least, Ctrl-H when Replace is open doesn't close the dialogue, it opens LibreOffice help. (In reply to comment #8) > For those who disagree with this bug, please read my rationale and respond > to it fully, addressing each of the issues I have raised with current > behaviour. I think it makes sense to revert the Ctrl+F to the 4.0 branch behaviour AND remove the toggle from Ctrl+H (for consistency) since Esc is already assigned to dismiss both. I also think that the Find toolbar should NOT be cleared when dismissed but should keep the last searched string (like the Find & Replace dialog does) Maybe my original request should have been to remove the toggle from Find&Replace instead of adding it to the Find toolbar. Comparing to the Mozilla Firefox usability I realize now it makes more sense. I apologize to Joren. I have updated the patch so that it now selects the text in the search box if you hit Ctrl+F and the search bar is open already. Concerning the toggle for Ctrl+H: I had a quick look, but that toggle logic is bound to some other dialogs and one would have to check that the other dialogs keep working. But this is really a minor issue. I suggest creating a new bug for this and making an Easy Hack out of it. Btw here's the patch: https://gerrit.libreoffice.org/#/c/11110/ Samuel Mehrbrodt committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=fa857d0beb8b7f800131d9f4ef3cfa61d20d39f7 fdo#82502 Ctrl-F should select the text in the search bar, not close it The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.