Bug 828

Summary: hppa linux build broken
Product: xorg Reporter: Donnie Berkholz <dberkholz>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: gmsoft, roland.mainz
Version: git   
Hardware: x86 (IA32)   
OS: Linux (All)   
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 351    
Description Flags
6.7.0-hppa-fixes.patch none

Description Donnie Berkholz 2004-07-06 03:00:55 UTC
One of our hppa guys gave this patch to me and told me it was necessary to fix
hppa compiles. Let me know if there's a problem with it, and I'll bug him.
Comment 1 Donnie Berkholz 2004-07-06 03:01:23 UTC
Created attachment 443 [details] [review]
Comment 2 Donnie Berkholz 2004-07-06 03:14:59 UTC
Credit to Guy Martin <gmsoft@gentoo.org>.
Comment 3 Paul Anderson 2004-08-05 21:26:19 UTC
Please adjust the test from

#ifdef __hppa__ 


#if defined(hpux) || defined __hppa__

Otherwise, this change may break builds on HP-UX.
If other patches have gone in that simply substitute
__hppa__ for hpux, we'll need to look at those as well.

This brings up another side issue.  It appears that
"HPArchitecture" in the config files has been overloaded.
Historically, it was used for HP-UX builds, but it looks
like it is now being used to denote builds on HP-PA
architectures (see Imake.cf, linux.cf).  Sometime in
the future, we should reexamine this and see if we need
to make any changes so that both builds can co-exist 
in the same tree. 
Comment 4 Donnie Berkholz 2004-08-07 18:55:02 UTC
Guy, can you please add an updated patch reflecting the above comments? I don't
have any access to Linux at the moment.
Comment 5 Kevin E. Martin 2004-08-09 15:40:29 UTC
I've made these changes and checked them in.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.