Bug 82842

Summary: [BYT-M]System unable go to S4 sporadically
Product: DRI Reporter: Guo Jinxian <jinxianx.guo>
Component: DRM/IntelAssignee: Imre Deak <imre.deak>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: intel-gfx-bugs
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
add missing freeze/power_off handlers
none
dmesg none

Description Guo Jinxian 2014-08-20 06:12:29 UTC 
==System Environment==
--------------------------
Regression: Not sure.
Result on -next-queued(5193109cd669c7990b043a7187548546c16f8af3) was "System unable resume from S3/S4 "(Bug 81948)

Non-working platforms: BYT-M

==kernel==
--------------------------
origin/drm-intel-nightly: 49ceddc7b3b0e3f7eb21b9fb4c9b840cff630047(fails)
    drm-intel-nightly: 2014y-08m-19d-19h-02m-49s integration manifest
origin/drm-intel-next-queued: 3f72c7b12f1a81a32fd37216b3382e6fe46a7184(fails)
    drm/i915/bdw: Disable execlists by default
origin/drm-intel-fixes: 1a125d8a2c22b11741fc47d4ffcf7a5ffa044dd3(fails)
    drm/i915: don't try to retrain a DP link on an inactive CRTC

==Bug detailed description==
-----------------------------
Input 'echo disk >/sys/power/state' and press enter, the screen will light off, but the power light still light on, and the cpu fan still working.

The reproduce rate about 1 out of 10.

System unable resume from S3/S4 before(Bug 81948)

Because of system had no responding, unable to get dmesg. 

==Reproduce steps==
---------------------------- 
1. echo disk >/sys/power/state
Comment 1 Imre Deak 2014-08-21 15:09:03 UTC 
Created attachment 105049 [details] [review]
add missing freeze/power_off handlers

Could you try the attached fix?
Comment 2 Guo Jinxian 2014-08-22 02:38:26 UTC 
Created attachment 105072 [details]
dmesg

(In reply to comment #1)
> Created attachment 105049 [details] [review] [review]
> add missing freeze/power_off handlers
> 
> Could you try the attached fix?

With this patch, I tried 10 time, system always able go to S4, but the eDP unable to light up after resume from S4.

And I met system unable to resume from S4 one time during the testing.
Comment 3 Imre Deak 2014-08-22 03:18:38 UTC 
(In reply to comment #2)
> Created attachment 105072 [details]
> dmesg
> 
> (In reply to comment #1)
> > Created attachment 105049 [details] [review] [review] [review]
> > add missing freeze/power_off handlers
> > 
> > Could you try the attached fix?
> 
> With this patch, I tried 10 time, system always able go to S4, but the eDP
> unable to light up after resume from S4.
> 
> And I met system unable to resume from S4 one time during the testing.

Did you try this on -next-queued? If so could you try it on -nightly? It has some additional eDP fixes.
Comment 4 Guo Jinxian 2014-08-22 08:38:38 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > Created attachment 105072 [details]
> > dmesg
> > 
> > (In reply to comment #1)
> > > Created attachment 105049 [details] [review] [review] [review] [review]
> > > add missing freeze/power_off handlers
> > > 
> > > Could you try the attached fix?
> > 
> > With this patch, I tried 10 time, system always able go to S4, but the eDP
> > unable to light up after resume from S4.
> > 
> > And I met system unable to resume from S4 one time during the testing.
> 
> Did you try this on -next-queued? If so could you try it on -nightly? It has
> some additional eDP fixes.

On latest -nightly(257d90d13794c2eb545ab0d6c708f21e2a0378b6) with this patch, S4 works well, doesn't meet the failures above.
Comment 5 Imre Deak 2014-09-11 15:05:05 UTC 
Could you try the following branch:
https://github.com/ideak/linux/commits/suspend-fix
Comment 6 Guo Jinxian 2014-09-12 07:08:03 UTC 
(In reply to comment #5)
> Could you try the following branch:
> https://github.com/ideak/linux/commits/suspend-fix

I tried 10 time on BYT-M whit this branch, and didn't reproduce this failure.

commit: 99f707d03c6bf4ad2c3fbfc721031db36a5de27a

commit 99f707d03c6bf4ad2c3fbfc721031db36a5de27a
Author: Imre Deak <imre.deak@intel.com>
Date:   Thu Aug 28 16:41:28 2014 +0300

    drm/i915: add comments on what stage a given PM handler is called

    This will hopefully make it easier to navigate the code without the need
    to consult the full PM documentation.

    Signed-off-by: Imre Deak <imre.deak@intel.com>
Comment 7 Jani Nikula 2014-09-12 07:36:21 UTC 
Just for reference,
http://mid.gmane.org/1410362229-814-1-git-send-email-imre.deak@intel.com

Imre, please ensure the bugzilla tags will be in place.
Comment 8 Imre Deak 2014-10-24 10:04:45 UTC 
(In reply to Jani Nikula from comment #7)
> Just for reference,
> http://mid.gmane.org/1410362229-814-1-git-send-email-imre.deak@intel.com
> 
> Imre, please ensure the bugzilla tags will be in place.

Hrm, forgot to add the tag to the patch and it's merged now. It is:

commit 8e003d97ad9d37fcd51a89652321f54c2ba96796
Author: Imre Deak <imre.deak@intel.com>
Date:   Wed Sep 10 18:16:54 2014 +0300

    drm/i915: vlv: fix gunit HW state corruption during S4 suspend
 
Setting this to fixed now as it's merged to -nightly along with other S3/S4 fixes.
Comment 9 Li Xu 2014-11-13 09:26:12 UTC 
With this patch and the tag, I tried 10 time, system always able go to S4, and it seems that all things goes well. System can resume from S4 every time of the 10.
Comment 10 Elizabeth 2017-10-06 14:36:37 UTC 
Closing old verified.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.