Bug 8292

Summary:	i915: texture crossbar
Product:	Mesa	Reporter:	Frank Richter <resqu>
Component:	Drivers/DRI/i915	Assignee:	Default DRI bug account <dri-devel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	MageSource, mat, sndirsch
Version:	git
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	i915 texture crossbar patch

Description Frank Richter 2006-09-15 19:15:42 UTC

If I interpret the spec right, texture crossbar means that for a GL_TEXTUREn
source the texture from unit n is sampled with texture coordinates n, which
isn't that to do hard with fragment programs (unless I missed something?).
Attached a patch with an attempted crossbar support implementation.

Comment 1 Frank Richter 2006-09-15 19:16:08 UTC

Created attachment 7002 [details] [review]
i915 texture crossbar patch

Comment 2 Keith Whitwell 2006-09-16 00:24:39 UTC

An even better approach is just to switch over to using texenvprogram.c to
generate the program.  I posted a patch for this a while ago and I've also
applied that patch on the texmem branches and consequently removed i915_texprog.c. 

If you're interested in i915 development, it probably makes sense to jump onto
that branch (texmem-0-3-branch) as there is a lot of good stuff that's been done
there and we're getting very close to a trunk merge...

Comment 3 Stefan Dirsch 2006-10-09 11:36:15 UTC

Index: src/mesa/drivers/dri/i915/i915_texprog.c
[...]
-        p->src_texture = i915_emit_texld( p, tmp, A0_DEST_CHANNEL_ALL, 
+        p->src_texture[unit] = i915_emit_texld( p, tmp, A0_DEST_CHANNEL_ALL, 
                                          sampler, texcoord, op );

Hmm. This is the wrong amount of parameters ...

Comment 4 Stefan Dirsch 2006-10-09 11:38:30 UTC

Argh. I've meant this one:

-        p->src_texture = i915_emit_texld( p, tmp, A0_DEST_CHANNEL_ALL, 
+        p->src_texture[unit] = i915_emit_texld( p, 0, tmp, 
A0_DEST_CHANNEL_ALL, 
                                          sampler, texcoord, op );

Comment 5 Gordon Jin 2007-03-14 19:32:46 UTC

The bug priority was upgraded (P2->high) with the bugzilla configuration change.
I'm Changing the priority back to the normal one.
Sorry for the spam.

Comment 6 Eric Anholt 2007-09-24 13:38:22 UTC

Crossbar support was brought in a different way with i915tex_dri.so merge.

Comment 7 Anthony J Clink 2007-10-09 17:06:42 UTC

(In reply to comment #1)
> Created an attachment (id=7002) [details]
> i915 texture crossbar patch
> 

How do I apply this patch?

Comment 8 Eric Anholt 2007-10-10 13:50:03 UTC

No need to apply any patch.  Use mesa master.

Comment 9 Anthony J Clink 2007-10-11 13:19:41 UTC

how do I use Mesa master? I am on a FC6 box, and am reletivly new to the linux experience.

Comment 10 Adam Jackson 2009-08-24 12:24:29 UTC

Mass version move, cvs -> git

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.