Bug 8321

Summary:	Replace pc(%m) symbols by pc
Product:	xkeyboard-config	Reporter:	Denis Barbier <barbier>
Component:	General	Assignee:	xkb
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	high
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Replace pc(%m) by pc Unbreak compatibility

Description Denis Barbier 2006-09-18 03:39:13 UTC

Hi,

all pc(pc10x) symbols have always been subsets of pc(pc105),
and in fact are useless.  This became even more visible
with last commits, so let's step further and remove all
those unneeded definitions.
I also remove lines with us(%mcompose) from rules/base.ml_s.part
because AFAICT xkeyboard-config never shipped these variants.
Patch follows.

Comment 1 Denis Barbier 2006-09-18 03:39:54 UTC

Created attachment 7043 [details] [review]
Replace pc(%m) by pc

Comment 2 Sergey V. Udaltsov 2006-09-18 04:46:01 UTC

Well, I am committing it. Though I have to admit we are breaking XkbSymbols
compatibility again;)

Comment 3 Denis Barbier 2006-09-18 23:53:08 UTC

Created attachment 7067 [details] [review]
Unbreak compatibility

My main point was to get rid of pc(%m) because it can
always be replaced by pc(pc105).  If compatibility is
an issue, this patch should fix it, and we could
remove symbols/pc(pc10{1,2,4}) after some time.

Comment 4 Sergey V. Udaltsov 2006-09-24 12:17:37 UTC

Denis, I looked at your patch - probably we'd be better off without this
compatibility bit. Actually, our promise is to keep compatibility on the
layout/model/option level, not on the symbols level - so let's wait and see if
we get complains over this breakage.

Comment 5 Denis Barbier 2006-09-29 02:45:49 UTC

For the record, I am not comfortable with a possible
breakage and decided to apply this patch in the Debian
package for our next release, it will be dropped
afterwards.

Comment 6 Sergey V. Udaltsov 2006-09-29 12:37:44 UTC

OK, I understand your position. Hopefully eventually we'll get in sync again-:)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.