| Summary: | Features disabled by default should also appear in cairo-features.h | ||
|---|---|---|---|
| Product: | cairo | Reporter: | Julien Isorce <julien.isorce> |
| Component: | general | Assignee: | Chris Wilson <chris> |
| Status: | RESOLVED FIXED | QA Contact: | cairo-bugs mailing list <cairo-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | freedesktop |
| Version: | 1.12.16 | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
build: define no features as 0
build: show up all disabled featured |
||
Whoever sets -Werror is doomed to live to suffer from it. Oki np. (webkitEFL enables it but I can disable it manually) What about the first part of the patch: -CAIRO_FEATURE_HOOK_REGISTER(no,!no,!, +CAIRO_FEATURE_HOOK_REGISTER(no,*,!, ? to have all the disabled features in the commentaries ( i.e. "/*#undef $FEATURE */" ) So that it's not confusing why in cairo-features.h you can see /*#undef CAIRO_HAS_EGL_FUNCTIONS */ but not /*#undef CAIRO_HAS_GLESV2_SURFACE */ when configuring cairo with --disable-egl --disable-glesv2 Thx! Ok I think that's fair. Created attachment 105673 [details] [review] build: show up all disabled featured The patch can go in, if someone can take care of committing and testing please. Based on Behdad's approval above, I've landed the patch in trunk. commit f032133e6d5ad05157fc46609d8c63103028342c Author: Julien Isorce <j.isorce@samsung.com> Date: Wed Sep 3 10:58:18 2014 +0100 build: Show all disabled features in cairo-features.h Even features which are disabled by default should appear in cairo-features.h. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83359 (Patch approved by Behdad Esfahbod in bug tracker.) Reviewed-by: Bryce Harrington <bryce@osg.samsung.com> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 105566 [details] build: define no features as 0 Currently in cairo-gl.h there is: #if CAIRO_HAS_GL_SURFACE || CAIRO_HAS_GLESV2_SURFACE When building cairo with --disable-glesv2 then the compiler warns that CAIRO_HAS_GLESV2_SURFACE is not defined. If those warnings are treated as errors then the build just fails (ex: webkit) The attached patch ensure all stuffs under put in NO_FEATURES are defined as 0, even for features defaulted to "no". Because currently only features defaults to auto or yes are put into NO_FEATURES when disabled.