Summary: | Un-virtual-ize Stream::getRawChar() for 35-45% speed boost for some pages | ||
---|---|---|---|
Product: | poppler | Reporter: | Krzysztof Kowalczyk <kkowalczyk> |
Component: | general | Assignee: | poppler-bugs <poppler-bugs> |
Status: | RESOLVED INVALID | QA Contact: | |
Severity: | normal | ||
Priority: | high | ||
Version: | unspecified | ||
Hardware: | x86 (IA32) | ||
OS: | Windows (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | un-virtual-ize getRawChar() |
Description
Krzysztof Kowalczyk
2006-09-19 01:39:39 UTC
Created attachment 7068 [details] [review] un-virtual-ize getRawChar() As described in bug. Nevermind, this patch is wrong. It always calls the getRawChar in IGetRawChar, not in the class I want. Which is why they invented virtual in C++, but I wanted to get rid of virtual, so this is no good. More testing next time before I post a patch. ;-) BTW, did you see you already have the cvs account? Once krh creates the 0.6 branch you can start commiting all your nice patches there! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.