Bug 83657

Summary:	Minimal syntax checking is done on server specs provided via --server or $PULSE_SERVER
Product:	PulseAudio	Reporter:	hortplumber
Component:	misc	Assignee:	pulseaudio-bugs
Status:	RESOLVED MOVED	QA Contact:	pulseaudio-bugs
Severity:	minor
Priority:	medium	CC:	lennart
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description hortplumber 2014-09-09 10:02:09 UTC

Many forms of invalid server specifications provided via --server or PULSE_SERVER envar do not get flagged as syntax errors.

Example:

  $ pactl -s '*()&#$' list
  Connection failure: Connection refused  

Flagging the server spec as invalid would help to avoid user footshoot.

Comment 1 Peter Meerwald 2014-11-15 15:15:47 UTC

these characters are all valid in a path name, i.e. a unix domain socket specifier

Comment 2 hortplumber 2014-11-15 16:17:48 UTC

I would argue that most mistyped strings (such as the example given above in the ticket) are invalid AF_UNIX socket specifiers, because they do not begin with '/'.


This argument seems to be supported by item #2 from

   http://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/ServerStrings/

and is also consistent with the AF_UNIX socket naming convention here

   http://www.freedesktop.org/software/systemd/man/systemd.socket.html


under the "Options" subsection.

Comment 3 GitLab Migration User 2018-07-30 09:54:52 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/119.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.