Bug 83697

Summary: [IVB/BYT/BDW/BSW]Piglit spec_ARB_draw_indirect_gl_VertexID_used_with_glDrawArraysIndirect fails
Product: Mesa Reporter: lu hua <huax.lu>
Component: Drivers/DRI/i965Assignee: Ian Romanick <idr>
Status: VERIFIED FIXED QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: normal    
Priority: medium CC: itoral
Version: unspecified   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description lu hua 2014-09-10 02:05:52 UTC
System Environment:
--------------------------
Platform: IVB
Libdrm:		(master)libdrm-2.4.56-21-g8c2ae1695913990cbe6c6a8aa294f354eba33bd0
Mesa:		(master)4ea1565bbc49df79d4c39ba5491b0a83c2679a05
server:	(master)xorg-server-1.16.0-152-g3a51418b2db353519a1779cf3cebbcc9afba2520
Xf86_video_intel:(master)2.99.916-2-ge0f7e9fc2f0b39b9e939ff48edea29950f125420
Libva:		(master)e0d25ece01e7aba819c910e98c4fb4706cdab055
Libva_intel_driver:(master)b18479e4fdd7af7cf2840542ef19dbe9114fdeaf
Kernel:   (drm-intel-nightly)4a3d32734bdcef6813b31f06a58430436e98711e

Bug detailed description:
---------------------------
It fails on IVB/BYT/BDW/BSW with mesa master or 10.3 branch. It's a new case.
spec_ARB_draw_indirect_gl_VertexID_used_with_glDrawElementsIndirect also fails.

output:
Using glDrawArraysIndirect...
Probe color at (0,0)
  Expected: 0.000000 1.000000 0.000000 1.000000
  Observed: 1.000000 0.000000 0.000000 1.000000
Probe color at (80,0)
  Expected: 0.000000 0.000000 1.000000 1.000000
  Observed: 1.000000 0.000000 0.000000 1.000000
Probe color at (0,80)
  Expected: 1.000000 1.000000 0.000000 1.000000
  Observed: 1.000000 0.000000 0.000000 1.000000
Probe color at (80,80)
  Expected: 1.000000 0.000000 1.000000 1.000000
  Observed: 1.000000 0.000000 0.000000 1.000000
PIGLIT: {"result": "fail" }


Reproduce steps:
-------------------------
1. xinit
2. bin/arb_draw_indirect-vertexid -fbo -auto
Comment 1 Iago Toral 2014-09-11 13:45:03 UTC
This works for me on IVB with master (f976b4c1bf2271cf):

$ bin/arb_draw_indirect-vertexid -fbo -auto
Using glDrawArraysIndirect...
PIGLIT: {"result": "pass" }
Comment 2 lu hua 2014-09-12 03:43:40 UTC
It works well on latest mesa master branch.
It still fails on Mesa 10.3 branch.
output(BDW):
Using glDrawArraysIndirect...
Probe color at (0,0)
  Expected: 0.000000 1.000000 0.000000 1.000000
  Observed: 1.000000 0.000000 0.000000 1.000000
Probe color at (80,0)
  Expected: 0.000000 0.000000 1.000000 1.000000
  Observed: 1.000000 0.000000 0.000000 1.000000
Probe color at (0,80)
  Expected: 1.000000 1.000000 0.000000 1.000000
  Observed: 1.000000 0.000000 0.000000 1.000000
Probe color at (80,80)
  Expected: 1.000000 0.000000 1.000000 1.000000
  Observed: 1.000000 0.000000 0.000000 1.000000
PIGLIT: {"result": "fail" }
Comment 3 Samuel Iglesias Gonsálvez 2014-09-15 09:17:33 UTC
After a git bisect, I found that the commit that fixes this issue in master is:

commit 927f5db46135b3eb63f401833b1e40a3be9ca4e0
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Fri Jun 20 16:26:35 2014 -0700

    i965: Request lowering gl_VertexID
    
    Fixes the (new) piglit tests gles-3.0-drawarrays-vertexid,
    gl-3.0-multidrawarrays-vertexid, and gl-3.2-basevertex-vertexid.
    
    Fixes gles3conform failure in:
    
    ES3-CTS.gtf.GL3Tests.transform_feedback.transform_feedback_vertex_id
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80247
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>


If you cherry-pick it into mesa-10.3-rc3, the bug is fixed. As it's one of the commits listed in the pull request from Ian on Saturday (see http://lists.freedesktop.org/archives/mesa-stable/2014-September/001771.html), no further action is required.
Comment 4 lu hua 2014-09-22 01:59:46 UTC
Fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.