Bug 83994

Summary:	fix the xwayland test
Product:	Wayland	Reporter:	Pekka Paalanen <ppaalanen>
Component:	weston	Assignee:	Wayland bug list <wayland-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	83980
Attachments:	test failure: compositor log test failure: test log test failure: run log test failure: compositor log with WM_DEBUG

Description Pekka Paalanen 2014-09-17 13:09:43 UTC

The XWayland test in Weston is currently failing. Investigate why exactly, and what would make it work again.

Would also be nice to write another XWayland test that does not rely on DRI2.

Comment 1 Derek Foreman 2015-02-24 15:05:05 UTC

There's a new test now that usually works, but I'm still investigating a couple of potential race conditions in it.

The test works by checking for the presence of the WL_SUBSURFACE_ID atom and checking the name of the window manager.

Right now I need to investigate when the WL_SUBSURFACE_ID atom is interned - can the test launch before that occurs?  And whether the test can start before the window manager has created its support window.

Comment 2 Pekka Paalanen 2015-03-18 11:38:41 UTC

Created attachment 114438 [details]
test failure: compositor log

Comment 3 Pekka Paalanen 2015-03-18 11:39:08 UTC

Created attachment 114439 [details]
test failure: test log

Comment 4 Pekka Paalanen 2015-03-18 12:03:00 UTC

Created attachment 114440 [details]
test failure: run log

Hee, I reproduced it!

Looks like a Weston crash. Now if I decoded the backtrace right, it would be SEGVing at  xwayland/window-manager.c:645 which looks like it means hash_table_lookup() maybe returns NULL or something in weston_wm_handle_configure_notify().

It's a total bitch to reproduce.

Comment 5 Pekka Paalanen 2015-03-18 12:56:55 UTC

Created attachment 114441 [details]
test failure: compositor log with WM_DEBUG

I had distcheck running in loop for a good while and it eventually reproduced.

Attaching the server log with XWM debugging enabled.

Comment 6 Pekka Paalanen 2015-04-10 06:40:18 UTC

I think we can finally close this saga with having landed:

commit 493721499927a354375ea86cf7563bf107e6fb72
Author: Derek Foreman <derekf@osg.samsung.com>
Date:   Thu Apr 9 10:51:22 2015 -0500

    xwm: Add and use helper function for looking up windows in the hash table

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.